Re: [PATCH 00/43] i.MX6 Video capture

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Steve,

Am Samstag, den 07.06.2014, 14:56 -0700 schrieb Steve Longerbeam:
> Hi all,
> 
> This patch set adds video capture support for the Freescale i.MX6 SOC.
>
> It is a from-scratch standardized driver that works with community
> v4l2 utilities, such as v4l2-ctl, v4l2-cap, and the v4l2src gstreamer
> plugin. It uses the latest v4l2 interfaces (subdev, videobuf2).
> Please see Documentation/video4linux/mx6_camera.txt for it's full list
> of features!

That's quite a series to digest! I'll quickly go over the points that
jumped at me and then look at the core code (especially 08/43 and 39/43)
in detail.

> The first 38 patches:
> 
> - prepare the ipu-v3 driver for video capture support. The current driver
>   contains only video display functionality to support the imx DRM drivers.
>   At some point ipu-v3 should be moved out from under staging/imx-drm since
>   it will no longer only support DRM.

The move out of staging is now merged into drm-next with
c1a6e9fe82b46159af8cc4cf34fb51ee47862f05.
After this is merged into mainline, there should be no need to push i.MX
capture support through staging. It would be helpful if you could rebase
on top of that.

> - Adds the device tree nodes and OF graph bindings for video capture support
>   on sabrelite, sabresd, and sabreauto reference platforms.

I disagree with the way you organized the device tree, I'll comment in
the relevant patches.

> The new i.MX6 capture host interface driver is at patch 39.
> 
> To support the sensors found on the sabrelite, sabresd, and sabreauto,
> three patches add sensor subdev's for parallel OV5642, MIPI CSI-2 OV5640,
> and the ADV7180 decoder chip, beginning at patch 40.

Please don't introduce i.MX6-only sensor drivers. Those should live
under drivers/media/i2c and not be i.MX specific.

regards
Philipp