From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-media@vger.kernel.org, Pawel Osciak <pawel@osciak.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 27/26] v4l: vb2: Set data_offset to 0 for single-plane buffers
Date: Thu, 08 Nov 2012 17:36:29 +0100 [thread overview]
Message-ID: <1404204.ssiMvSrs8l@avalon> (raw)
In-Reply-To: <509BCF8C.3060806@samsung.com>
Hi Tomasz,
On Thursday 08 November 2012 16:28:12 Tomasz Stanislawski wrote:
> Hi Laurent,
> The fix was partially applied in "[PATCHv10 03/26] v4l: vb2: add support for
> shared buffer (dma_buf)". The data_offset is set to 0 for DMABUF
> capture/output for single-planar API.
My bad, I had an old version of your patch set in my git tree. The other half
of the patch should still be applied, but it can go through Mauro's tree
without going through yours.
> We should define the meaning of data_offset in case of USERPTR and MMAP
> buffers. For output device it is pretty intuitive.
>
> For DMABUF capture devices data_offset maybe used to inform a driver to
> capture the image at some offset inside the DMABUF buffer.
That's indeed missing from the documentation.
> BTW. Should {} be added after "if (V4L2_TYPE_IS_OUTPUT(b->type))"
> to avoid 'interesting' behavior? :)
Oops :-) I'll fix that.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-11-08 16:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:46 [PATCHv10 00/26] Integration of videobuf2 with DMABUF Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 01/26] v4l: Add DMABUF as a memory type Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 02/26] Documentation: media: description of DMABUF importing in V4L2 Tomasz Stanislawski
2012-10-15 7:53 ` Hans Verkuil
2012-10-10 14:46 ` [PATCHv10 03/26] v4l: vb2: add support for shared buffer (dma_buf) Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 04/26] v4l: vb: remove warnings about MEMORY_DMABUF Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 05/26] v4l: vb2-dma-contig: shorten vb2_dma_contig prefix to vb2_dc Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 06/26] v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 07/26] v4l: vb2-dma-contig: reorder functions Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 08/26] v4l: vb2-dma-contig: add support for scatterlist in userptr mode Tomasz Stanislawski
2012-10-26 16:24 ` Pawel Osciak
2012-10-30 6:43 ` Marek Szyprowski
2012-10-10 14:46 ` [PATCHv10 09/26] v4l: vb2: add prepare/finish callbacks to allocators Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 10/26] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 11/26] v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 12/26] v4l: vb2-vmalloc: add support for dmabuf importing Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 13/26] v4l: vivi: " Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 14/26] v4l: s5p-tv: mixer: " Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 15/26] v4l: s5p-fimc: " Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 16/26] v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 17/26] Documentation: media: description of DMABUF exporting in V4L2 Tomasz Stanislawski
2012-10-15 7:59 ` Hans Verkuil
2012-10-10 14:46 ` [PATCHv10 18/26] v4l: add buffer exporting via dmabuf Tomasz Stanislawski
2012-10-15 8:01 ` Hans Verkuil
2012-10-10 14:46 ` [PATCHv10 19/26] v4l: vb2: " Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 20/26] v4l: vb2-dma-contig: add support for DMABUF exporting Tomasz Stanislawski
2012-10-11 21:46 ` Laurent Pinchart
2012-10-10 14:46 ` [PATCHv10 21/26] v4l: vb2-dma-contig: add reference counting for a device from allocator context Tomasz Stanislawski
2012-10-11 21:49 ` Laurent Pinchart
2012-10-12 6:28 ` Tomasz Stanislawski
2012-10-12 9:32 ` Laurent Pinchart
2012-10-10 14:46 ` [PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned Tomasz Stanislawski
2012-10-11 21:36 ` Laurent Pinchart
2012-10-12 7:44 ` Tomasz Stanislawski
2012-10-12 7:58 ` Hans Verkuil
2012-10-12 9:34 ` Laurent Pinchart
2012-10-10 14:46 ` [PATCHv10 23/26] v4l: vb2-dma-contig: align buffer size to PAGE_SIZE Tomasz Stanislawski
2012-10-11 21:31 ` Laurent Pinchart
2012-10-12 8:24 ` Tomasz Stanislawski
2012-10-16 12:22 ` Laurent Pinchart
2012-10-10 14:46 ` [PATCHv10 24/26] v4l: s5p-fimc: support for dmabuf exporting Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 25/26] v4l: s5p-tv: mixer: " Tomasz Stanislawski
2012-10-10 14:46 ` [PATCHv10 26/26] v4l: s5p-mfc: " Tomasz Stanislawski
2012-11-08 12:05 ` [PATCH 27/26] v4l: vb2: Set data_offset to 0 for single-plane buffers Laurent Pinchart
2012-11-08 12:13 ` Marek Szyprowski
2012-11-08 12:19 ` Laurent Pinchart
2012-11-08 15:28 ` Tomasz Stanislawski
2012-11-08 16:36 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404204.ssiMvSrs8l@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).