From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Pawel Osciak <pawel@osciak.com>
Subject: Re: [RFC PATCH] Docbook/media: improve data_offset/bytesused documentation
Date: Mon, 21 Jul 2014 09:30:58 -0400 [thread overview]
Message-ID: <1405949458.2258.4.camel@mpb-nicolas> (raw)
In-Reply-To: <53CD12BF.9050202@xs4all.nl>
Le lundi 21 juillet 2014 à 15:16 +0200, Hans Verkuil a écrit :
> + Note that data_offset is included in <structfield>bytesused</structfield>.
> + So the size of the image in the plane is
> + <structfield>bytesused</structfield>-<structfield>data_offset</structfield> at
> + offset <structfield>data_offset</structfield> from the start of the plane.
This seem like messing applications a lot. Let's say you have a well
known format, NV12, but your driver add some customer header at the
beginning. Pretty much all the application in the world would work just
fine ignoring that header, but in fact most of them will not work,
because bytesused is including the header. Considering this wasn't
documented before, I would strongly suggest to keep the bytesused as
being the size for the format know by everyone.
next prev parent reply other threads:[~2014-07-21 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 13:16 [RFC PATCH] Docbook/media: improve data_offset/bytesused documentation Hans Verkuil
2014-07-21 13:30 ` Nicolas Dufresne [this message]
2014-07-25 7:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405949458.2258.4.camel@mpb-nicolas \
--to=nicolas.dufresne@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox