From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from smtprelay0153.hostedemail.com ([216.40.44.153]:50986 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752561AbaHDLMS (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Mon, 4 Aug 2014 07:12:18 -0400
Message-ID: <1407150732.16152.59.camel@joe-AO725>
Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with
 dev_dbg()
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Martin Kepplinger <martink@posteo.de>, gregkh@linuxfoundation.org,
	devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, m.chehab@samsung.com
Date: Mon, 04 Aug 2014 04:12:12 -0700
In-Reply-To: <20140804104016.GQ4804@mwanda>
References: <20140804091023.GP4856@mwanda>
	 <1407147434-27732-1-git-send-email-martink@posteo.de>
	 <20140804104016.GQ4804@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Mon, 2014-08-04 at 13:40 +0300, Dan Carpenter wrote:
> On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
[]
> > +	if (dev) {
> > +		dev_dbg(&dev->bus_adap.usb_dev->dev,
> > +		"tuner parameters: freq: %d  bw: 0x%02x  gi: 0x%02x\n",
> > +			params->frequency,
> > +			tune_args->bandwidth,
> > +			tune_args->guard_interval);
> > +	} else {
> > +	pr_debug("as102: tuner parameters: freq: %d  bw: 0x%02x  gi: 0x%02x\n",
> >  			params->frequency,
> >  			tune_args->bandwidth,
> >  			tune_args->guard_interval);
> > +	}
[]
> This isn't indented correctly.  I wish checkpatch.pl would catch that...
> Anyway, the else side can be removed as explained earlier.

checkpatch doesn't warn on any of:

$ cat t.c
static int func(void **bar)
{
	bool b;
			/* test */
		int a[2] = {
			3,
				6
	};

		if (b) {
			b = a[0] == a[1];
	}
			return a[b];
	}
$

I think it'd be better if it would one day
but it doesn't seem as simple as it seems
for checkpatch to do it.