Re: [PATCH v3 29/33] omap3isp: Configure CSI-2 phy based on platform data

Sakari Ailus
2012-02-25T01:49:29Z

On Wed, Feb 22, 2012 at 12:21:50PM +0100, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thanks for the patch.
>
> On Monday 20 February 2012 03:57:08 Sakari Ailus wrote:
> > Configure CSI-2 phy based on platform data in the ISP driver. For that, the
> > new V4L2_CID_IMAGE_SOURCE_PIXEL_RATE control is used. Previously the same
> > was configured from the board code.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>
> [snip]
>
> > diff --git a/drivers/media/video/omap3isp/ispcsiphy.c
> > b/drivers/media/video/omap3isp/ispcsiphy.c index 5be37ce..902477d 100644
> > --- a/drivers/media/video/omap3isp/ispcsiphy.c
> > +++ b/drivers/media/video/omap3isp/ispcsiphy.c
> > @@ -28,41 +28,13 @@
> > #include <linux/device.h>
> > #include <linux/regulator/consumer.h>
> >
> > +#include "../../../../arch/arm/mach-omap2/control.h"
>
> I expect you will have to fix that somehow, but as far as I'm concerned,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks. I don't think I like this any more than you do, but my understandint
is there is no good solution to this _right now_, and the proper solution
won't be that far away anyway, so I just intend to keep it as-is for now.

Cheers,

--
Sakari Ailus
e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk