* [PATCH] dvb:tc90522: bugfix of always-false expression
@ 2014-10-26 12:05 tskd08
2014-10-26 12:15 ` Antti Palosaari
0 siblings, 1 reply; 6+ messages in thread
From: tskd08 @ 2014-10-26 12:05 UTC (permalink / raw)
To: linux-media; +Cc: m.chehab, Akihiro Tsukada
From: Akihiro Tsukada <tskd08@gmail.com>
Reported by David Binderman
---
drivers/media/dvb-frontends/tc90522.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c
index d9905fb..bca81ef 100644
--- a/drivers/media/dvb-frontends/tc90522.c
+++ b/drivers/media/dvb-frontends/tc90522.c
@@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe)
u8 v;
c->isdbt_partial_reception = val[0] & 0x01;
- c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01;
+ c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40;
/* layer A */
v = (val[2] & 0x78) >> 3;
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dvb:tc90522: bugfix of always-false expression
2014-10-26 12:05 [PATCH] dvb:tc90522: bugfix of always-false expression tskd08
@ 2014-10-26 12:15 ` Antti Palosaari
2014-10-26 13:58 ` Akihiro TSUKADA
0 siblings, 1 reply; 6+ messages in thread
From: Antti Palosaari @ 2014-10-26 12:15 UTC (permalink / raw)
To: tskd08, linux-media; +Cc: m.chehab
On 10/26/2014 02:05 PM, tskd08@gmail.com wrote:
> From: Akihiro Tsukada <tskd08@gmail.com>
>
> Reported by David Binderman
^^ See Documentation/SubmittingPatches
Antti
> ---
> drivers/media/dvb-frontends/tc90522.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c
> index d9905fb..bca81ef 100644
> --- a/drivers/media/dvb-frontends/tc90522.c
> +++ b/drivers/media/dvb-frontends/tc90522.c
> @@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe)
> u8 v;
>
> c->isdbt_partial_reception = val[0] & 0x01;
> - c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01;
> + c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40;
>
> /* layer A */
> v = (val[2] & 0x78) >> 3;
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dvb:tc90522: bugfix of always-false expression
2014-10-26 12:15 ` Antti Palosaari
@ 2014-10-26 13:58 ` Akihiro TSUKADA
2014-10-26 16:27 ` Antti Palosaari
0 siblings, 1 reply; 6+ messages in thread
From: Akihiro TSUKADA @ 2014-10-26 13:58 UTC (permalink / raw)
To: Antti Palosaari, linux-media; +Cc: m.chehab
>> Reported by David Binderman
>
> ^^ See Documentation/SubmittingPatches
Though I knew that Reported-by: tag should not be used,
I wrote it just to express my appreciation for his report,
and did not mean to attach the tag.
But I admit that it is confusing,
so I'd like to beg Mauro to do me the kindness
to delete the line when this patch is committed.
(or I'll re-send the patch if it is necessary.)
regards,
akihiro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dvb:tc90522: bugfix of always-false expression
2014-10-26 13:58 ` Akihiro TSUKADA
@ 2014-10-26 16:27 ` Antti Palosaari
2014-11-03 14:37 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Antti Palosaari @ 2014-10-26 16:27 UTC (permalink / raw)
To: Akihiro TSUKADA, linux-media; +Cc: m.chehab
On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote:
>>> Reported by David Binderman
>>
>> ^^ See Documentation/SubmittingPatches
>
> Though I knew that Reported-by: tag should not be used,
> I wrote it just to express my appreciation for his report,
> and did not mean to attach the tag.
> But I admit that it is confusing,
> so I'd like to beg Mauro to do me the kindness
> to delete the line when this patch is committed.
> (or I'll re-send the patch if it is necessary.)
Main reason I picked it up, was that tag was formally bad.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dvb:tc90522: bugfix of always-false expression
2014-10-26 16:27 ` Antti Palosaari
@ 2014-11-03 14:37 ` Mauro Carvalho Chehab
2014-11-03 15:06 ` Akihiro TSUKADA
0 siblings, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2014-11-03 14:37 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Akihiro TSUKADA, linux-media
Em Sun, 26 Oct 2014 18:27:28 +0200
Antti Palosaari <crope@iki.fi> escreveu:
>
>
> On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote:
> >>> Reported by David Binderman
> >>
> >> ^^ See Documentation/SubmittingPatches
> >
> > Though I knew that Reported-by: tag should not be used,
> > I wrote it just to express my appreciation for his report,
> > and did not mean to attach the tag.
> > But I admit that it is confusing,
> > so I'd like to beg Mauro to do me the kindness
> > to delete the line when this patch is committed.
> > (or I'll re-send the patch if it is necessary.)
>
> Main reason I picked it up, was that tag was formally bad.
Yeah, the tag should be Reported-by: and should have the email
of the person who reported the issue.
But that's not the only thing you forgot... there's no SOB on
this patch ;)
Please resend.
Regards,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dvb:tc90522: bugfix of always-false expression
2014-11-03 14:37 ` Mauro Carvalho Chehab
@ 2014-11-03 15:06 ` Akihiro TSUKADA
0 siblings, 0 replies; 6+ messages in thread
From: Akihiro TSUKADA @ 2014-11-03 15:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media
I already posted v2 to this ML,
but it was at top-level, not in-reply-to this thread.
Sorry for the confusing posts.
v2 of this patch:
https://patchwork.linuxtv.org/patch/26652/
and the other two patches
https://patchwork.linuxtv.org/patch/26651/
https://patchwork.linuxtv.org/patch/26653/
regards,
Akihiro
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-03 15:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-26 12:05 [PATCH] dvb:tc90522: bugfix of always-false expression tskd08
2014-10-26 12:15 ` Antti Palosaari
2014-10-26 13:58 ` Akihiro TSUKADA
2014-10-26 16:27 ` Antti Palosaari
2014-11-03 14:37 ` Mauro Carvalho Chehab
2014-11-03 15:06 ` Akihiro TSUKADA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).