From: William Towle <william.towle@codethink.co.uk>
To: linux-kernel@lists.codethink.co.uk, linux-media@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH 4/8] WmT: m-5mols_core style pad handling for adv7604
Date: Thu, 29 Jan 2015 16:19:44 +0000 [thread overview]
Message-ID: <1422548388-28861-5-git-send-email-william.towle@codethink.co.uk> (raw)
In-Reply-To: <1422548388-28861-1-git-send-email-william.towle@codethink.co.uk>
---
drivers/media/i2c/adv7604.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 30bbd9d..6ed9303 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -1976,7 +1976,11 @@ static int adv7604_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
struct v4l2_mbus_framefmt *fmt;
- fmt = v4l2_subdev_get_try_format(fh, format->pad);
+ fmt = (fh == NULL) ? NULL
+ : v4l2_subdev_get_try_format(fh, format->pad);
+ if (fmt == NULL)
+ return EINVAL;
+
format->format.code = fmt->code;
} else {
format->format.code = state->format->code;
@@ -2008,7 +2012,11 @@ static int adv7604_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh,
if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
struct v4l2_mbus_framefmt *fmt;
- fmt = v4l2_subdev_get_try_format(fh, format->pad);
+ fmt = (fh == NULL) ? NULL
+ : v4l2_subdev_get_try_format(fh, format->pad);
+ if (fmt == NULL)
+ return -EINVAL;
+
fmt->code = format->format.code;
} else {
state->format = info;
--
1.7.10.4
next prev parent reply other threads:[~2015-01-29 16:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 16:19 RFC: supporting adv7604.c under soc_camera/rcar_vin William Towle
2015-01-29 16:19 ` [PATCH 1/8] Add ability to read default input port from DT William Towle
2015-01-29 20:19 ` Jean-Michel Hautbois
2015-01-29 16:19 ` [PATCH 2/8] adv7604.c: formats, default colourspace, and IRQs William Towle
2015-01-29 16:19 ` [PATCH 3/8] WmT: document "adi,adv7612" William Towle
2015-01-29 16:19 ` William Towle [this message]
2015-01-29 20:23 ` [PATCH 4/8] WmT: m-5mols_core style pad handling for adv7604 Jean-Michel Hautbois
2015-02-04 14:14 ` William Towle
2015-02-04 14:40 ` Hans Verkuil
2015-01-29 16:19 ` [PATCH 5/8] media: rcar_vin: Add RGB888_1X24 input format support William Towle
2015-01-29 17:05 ` Sergei Shtylyov
2015-01-29 18:18 ` Guennadi Liakhovetski
2015-01-29 18:28 ` Sergei Shtylyov
2015-01-29 20:19 ` Guennadi Liakhovetski
2015-01-29 20:36 ` Sergei Shtylyov
2015-01-29 20:57 ` Guennadi Liakhovetski
2015-01-29 21:11 ` Guennadi Liakhovetski
2015-02-01 18:29 ` Guennadi Liakhovetski
2015-01-29 16:19 ` [PATCH 6/8] WmT: adv7604 driver compatibility William Towle
2015-01-31 23:56 ` Guennadi Liakhovetski
2015-02-01 11:26 ` Guennadi Liakhovetski
2015-02-02 10:01 ` Laurent Pinchart
2015-02-02 10:09 ` Hans Verkuil
2015-02-03 15:22 ` Laurent Pinchart
2015-02-03 15:24 ` Hans Verkuil
2015-02-03 15:29 ` Lars-Peter Clausen
2015-02-03 15:56 ` Laurent Pinchart
2015-02-03 15:55 ` Laurent Pinchart
2015-01-29 16:19 ` [PATCH 7/8] WmT: rcar_vin new ADV7612 support William Towle
2015-02-01 11:44 ` Guennadi Liakhovetski
2015-01-29 16:19 ` [PATCH 8/8] WmT: dts/i vin0/adv7612 (HDMI) William Towle
2015-01-29 16:51 ` Sergei Shtylyov
2015-02-01 15:51 ` RFC: supporting adv7604.c under soc_camera/rcar_vin Guennadi Liakhovetski
2015-03-04 9:51 ` [Linux-kernel] " William Towle
2015-03-04 10:19 ` Hans Verkuil
2015-03-05 8:58 ` William Towle
2015-03-25 9:55 ` William Towle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422548388-28861-5-git-send-email-william.towle@codethink.co.uk \
--to=william.towle@codethink.co.uk \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-media@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).