* [RFC] v4l2-ctl: don't exit on VIDIOC_QUERYCAP error for subdevices
@ 2015-03-26 9:21 Philipp Zabel
2015-03-26 16:48 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Zabel @ 2015-03-26 9:21 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil, Philipp Zabel
Subdevice nodes don't implement VIDIOC_QUERYCAP. This check doesn't
allow any operations on v42-subdev nodes, such as setting EDID.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
utils/v4l2-ctl/v4l2-ctl.cpp | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp
index b340af7..211372b 100644
--- a/utils/v4l2-ctl/v4l2-ctl.cpp
+++ b/utils/v4l2-ctl/v4l2-ctl.cpp
@@ -1149,10 +1149,7 @@ int main(int argc, char **argv)
}
verbose = options[OptVerbose];
- if (doioctl(fd, VIDIOC_QUERYCAP, &vcap)) {
- fprintf(stderr, "%s: not a v4l2 node\n", device);
- exit(1);
- }
+ doioctl(fd, VIDIOC_QUERYCAP, &vcap);
capabilities = vcap.capabilities;
if (capabilities & V4L2_CAP_DEVICE_CAPS)
capabilities = vcap.device_caps;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] v4l2-ctl: don't exit on VIDIOC_QUERYCAP error for subdevices
2015-03-26 9:21 [RFC] v4l2-ctl: don't exit on VIDIOC_QUERYCAP error for subdevices Philipp Zabel
@ 2015-03-26 16:48 ` Hans Verkuil
2015-03-26 17:09 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2015-03-26 16:48 UTC (permalink / raw)
To: Philipp Zabel, linux-media; +Cc: Hans Verkuil
On 03/26/2015 02:21 AM, Philipp Zabel wrote:
> Subdevice nodes don't implement VIDIOC_QUERYCAP. This check doesn't
> allow any operations on v42-subdev nodes, such as setting EDID.
Nack because I'm going to create a proper VIDIOC_SUBDEV_QUERYCAP for
subdevs. I'm planning to work on this next week.
Regards,
Hans
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> utils/v4l2-ctl/v4l2-ctl.cpp | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp
> index b340af7..211372b 100644
> --- a/utils/v4l2-ctl/v4l2-ctl.cpp
> +++ b/utils/v4l2-ctl/v4l2-ctl.cpp
> @@ -1149,10 +1149,7 @@ int main(int argc, char **argv)
> }
>
> verbose = options[OptVerbose];
> - if (doioctl(fd, VIDIOC_QUERYCAP, &vcap)) {
> - fprintf(stderr, "%s: not a v4l2 node\n", device);
> - exit(1);
> - }
> + doioctl(fd, VIDIOC_QUERYCAP, &vcap);
> capabilities = vcap.capabilities;
> if (capabilities & V4L2_CAP_DEVICE_CAPS)
> capabilities = vcap.device_caps;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] v4l2-ctl: don't exit on VIDIOC_QUERYCAP error for subdevices
2015-03-26 16:48 ` Hans Verkuil
@ 2015-03-26 17:09 ` Philipp Zabel
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2015-03-26 17:09 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, Hans Verkuil
Am Donnerstag, den 26.03.2015, 09:48 -0700 schrieb Hans Verkuil:
> On 03/26/2015 02:21 AM, Philipp Zabel wrote:
> > Subdevice nodes don't implement VIDIOC_QUERYCAP. This check doesn't
> > allow any operations on v42-subdev nodes, such as setting EDID.
>
> Nack because I'm going to create a proper VIDIOC_SUBDEV_QUERYCAP for
> subdevs. I'm planning to work on this next week.
Oh great, thanks for the heads-up.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-26 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 9:21 [RFC] v4l2-ctl: don't exit on VIDIOC_QUERYCAP error for subdevices Philipp Zabel
2015-03-26 16:48 ` Hans Verkuil
2015-03-26 17:09 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).