public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Pawel Osciak <pawel@osciak.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Kamil Debski <k.debski@samsung.com>,
	linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] [media] videobuf2: add trace events
Date: Thu, 25 Jun 2015 18:33:15 +0200	[thread overview]
Message-ID: <1435249995.3761.55.camel@pengutronix.de> (raw)
In-Reply-To: <20150625090724.09fb03f8@gandalf.local.home>

Am Donnerstag, den 25.06.2015, 09:07 -0400 schrieb Steven Rostedt:
> On Thu, 25 Jun 2015 12:01:27 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
> 
> > diff --git a/include/trace/events/v4l2.h b/include/trace/events/v4l2.h
> > index 89d0497..3d15cf1 100644
> > --- a/include/trace/events/v4l2.h
> > +++ b/include/trace/events/v4l2.h
> > @@ -175,9 +175,108 @@ SHOW_FIELD
> >  		)							\
> >  	)
> >  
> > +#define VB2_TRACE_EVENT(event_name)					\
> 
> This is what we have DECLARE_EVENT_CLASS for. Please use that,
> otherwise you are adding about 5k of text per event (where as
> DEFINE_EVENT adds only about 250 bytes).
[...]
> While you are at it, nuke the above macro and convert that too.

Thanks, I'll do that.

regards
Philipp


  reply	other threads:[~2015-06-25 16:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 10:01 [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does Philipp Zabel
2015-06-25 10:01 ` [PATCH 2/2] [media] videobuf2: add trace events Philipp Zabel
2015-06-25 13:07   ` Steven Rostedt
2015-06-25 16:33     ` Philipp Zabel [this message]
2015-06-25 13:11 ` [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does Sylwester Nawrocki
2015-06-25 15:12   ` Philipp Zabel
2015-06-26  8:28     ` Sylwester Nawrocki
2015-06-26  9:02       ` Philipp Zabel
2015-06-26  9:35         ` Sylwester Nawrocki
2015-06-25 14:10 ` Kamil Debski
2015-06-25 16:34   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435249995.3761.55.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=hans.verkuil@cisco.com \
    --cc=k.debski@samsung.com \
    --cc=kernel@pengutronix.de \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pawel@osciak.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox