public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	Mats Randgaard <matrandg@cisco.com>,
	linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 3/4] [media] tc358743: support probe from device tree
Date: Fri, 17 Jul 2015 16:06:37 +0200	[thread overview]
Message-ID: <1437141997.3254.6.camel@pengutronix.de> (raw)
In-Reply-To: <55A8F3A6.5030000@xs4all.nl>

Hi Hans,

Am Freitag, den 17.07.2015, 14:23 +0200 schrieb Hans Verkuil:
[...]
> > +	endpoint = v4l2_of_alloc_parse_endpoint(ep);
> > +	if (IS_ERR(endpoint)) {
> > +		dev_err(dev, "failed to parse endpoint\n");
> > +		return PTR_ERR(endpoint);
> > +	}
> > +
> > +	if (endpoint->bus_type != V4L2_MBUS_CSI2 ||
> > +	    endpoint->bus.mipi_csi2.num_data_lanes == 0 ||
> > +	    endpoint->nr_of_link_frequencies == 0) {
> > +		dev_err(dev, "missing CSI-2 properties in endpoint\n");
> > +		goto free_endpoint;
> > +	}
> > +
> > +	state->bus = endpoint.bus.mipi_csi2;
> 
> This should be endpoint->bus. You clearly didn't compile it.
> 
> Please make a v3, ensure that it compiles and please test it as well.

Sorry, fixed, tested, and resent.

regards
Philipp


  reply	other threads:[~2015-07-17 14:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 10:58 [PATCH v2 1/4] [media] tc358743: register v4l2 asynchronous subdevice Philipp Zabel
2015-07-17 10:58 ` [PATCH v2 2/4] [media] tc358743: enable v4l2 subdevice devnode Philipp Zabel
2015-07-17 10:58 ` [PATCH v2 3/4] [media] tc358743: support probe from device tree Philipp Zabel
2015-07-17 12:23   ` Hans Verkuil
2015-07-17 14:06     ` Philipp Zabel [this message]
2015-07-17 10:58 ` [PATCH v2 4/4] [media] tc358743: add direct interrupt handling Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437141997.3254.6.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=matrandg@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox