From: Philipp Zabel <p.zabel@pengutronix.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Kamil Debski <kamil@wypas.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-media@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] [media] v4l2: export videobuf2 trace points
Date: Tue, 28 Jul 2015 10:15:06 +0200 [thread overview]
Message-ID: <1438071306.3193.9.camel@pengutronix.de> (raw)
In-Reply-To: <55B73724.4040500@xs4all.nl>
Am Dienstag, den 28.07.2015, 10:02 +0200 schrieb Hans Verkuil:
> On 07/28/2015 09:55 AM, Philipp Zabel wrote:
> > If videobuf2-core is built as a module, the vb2 trace points must be
> > exported from videodev.o to avoid errors when linking videobuf2-core.
>
> I'm no tracepoint expert, so I'll just ask: if the tracepoint functionality
> is disabled in the kernel, will this still compile OK?
>
> That is, will the EXPORT_TRACEPOINT_SYMBOL_GPL() code disappear in that
> case or will it point to absent code/data?
No traces left if CONFIG_TRACEPOINTS not set. include/linux/tracepoint.h
contains:
#ifdef CONFIG_TRACEPOINTS
#define EXPORT_TRACEPOINT_SYMBOL_GPL(name) \
EXPORT_SYMBOL_GPL(__tracepoint_##name)
#else /* !CONFIG_TRACEPOINTS */
#define EXPORT_TRACEPOINT_SYMBOL_GPL(name)
#endif
regards
Philipp
prev parent reply other threads:[~2015-07-28 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 7:55 [PATCH] [media] v4l2: export videobuf2 trace points Philipp Zabel
2015-07-28 8:02 ` Hans Verkuil
2015-07-28 8:15 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438071306.3193.9.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=kamil@wypas.org \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel@osciak.com \
--cc=rostedt@goodmis.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox