Re: [PATCH 1/2] [media] coda: fix sequence counter increment

[Philipp Zabel <p.zabel@pengutronix.de>]

Am Dienstag, den 28.07.2015, 10:54 +0200 schrieb Hans Verkuil:
> On 07/08/2015 05:49 PM, Philipp Zabel wrote:
> > Hi Zahari,
> > 
> > Am Mittwoch, den 08.07.2015, 15:37 +0200 schrieb Zahari Doychev:
> >> The coda context queue sequence counter is incremented only if the vb2
> >> source buffer payload is non zero. This makes possible to signal EOS
> >> otherwise the condition in coda_buf_is_end_of_stream is never met or more
> >> precisely buf->v4l2_buf.sequence == (ctx->qsequence - 1) never happens.
> >>
> >> Signed-off-by: Zahari Doychev <zahari.doychev@linux.com>
> > 
> > I think we should instead avoid calling coda_bitstream_queue with zero
> > payload buffers altogether and dump them in coda_fill_bitstream already.
> 
> Philipp, is this still outstanding or did you fix this already according
> to the suggestion you made above?

> Just wondering whether to set this bug report to 'Rejected' or 'Changes
> Requested'.

Changes requested.

Is this something I should do myself for coda patches in the future?

regards
Philipp