From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E17C48BD7 for ; Thu, 27 Jun 2019 18:45:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A2AE2075E for ; Thu, 27 Jun 2019 18:45:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbfF0Spd (ORCPT ); Thu, 27 Jun 2019 14:45:33 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:48070 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbfF0Spd (ORCPT ); Thu, 27 Jun 2019 14:45:33 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 4BDF126D296 Message-ID: <143cb82ff2ff5c5f389109def45ee47b9ad076d8.camel@collabora.com> Subject: Re: [PATCH] media: imx: mipi csi-2: Don't fail if initial state times-out From: Ezequiel Garcia To: Philipp Zabel , Fabio Estevam Cc: Steve Longerbeam , Laurent Pinchart , kernel@collabora.com, Shawn Guo , Sascha Hauer , linux-media , Hans Verkuil , Nicolas Dufresne Date: Thu, 27 Jun 2019 15:45:24 -0300 In-Reply-To: <1561640172.4216.16.camel@pengutronix.de> References: <20190625203945.28081-1-ezequiel@collabora.com> <1561535121.4870.1.camel@pengutronix.de> <3797cdd2-f6c8-f23d-788c-b8efc3e75b21@gmail.com> <1561624997.4216.11.camel@pengutronix.de> <1561640172.4216.16.camel@pengutronix.de> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 2019-06-27 at 14:56 +0200, Philipp Zabel wrote: > Hi Fabio, > > On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote: > > Hi Philipp, > > > > On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel wrote: > > > > > Are there any visual artifacts in the first frame(s) in this case? > > > > I do not observe visual artifacts when running gst-launch-1.0 v4l2src ! kmssink > > > > > > So in my opinion the next version of this patch should make LP-11 > > > > timeout a warning only, but keep the error return on clock lane timeouts. > > > > > > I agree. > > > > Here is a reworked version of Ezequiel's patch as per the suggestions: > > http://code.bulix.org/g5qap5-780475 > > > > Does this one look good? > > Limiting the change to wait_stopstate is fine, the actual message > makes assumptions that could be misleading. How about: > > "Timeout waiting for LP-11 state on all active lanes. > This is most likely caused by a bug in the sensor driver. > Capture might fail or contain visual artifacts." > > I'd like to keep the phy_state register output though, if only as > dev_dbg(). It contains useful output for debugging, for example if only > some of the lanes are in stop state, which could indicate an issue with > connections or lane configuration. > > I think Philipp's suggestions looks very good, both the text and keeping the phy state. I think both should be kept in the warning. Fabio: feel free to submit a v2, or let me know so I'll add it to my TODO. Thanks, Eze