From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Subject: [v4l-utils PATCH 1/1] v4l: libv4l2subdev: Precisely convert media bus string to code
Date: Wed, 9 Dec 2015 17:14:47 +0200 [thread overview]
Message-ID: <1449674087-19122-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
The length of the string was ignored, making it possible for the
conversion to fail due to extra characters in the string.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
This patch should be applied before the set "[v4l-utils PATCH v2 0/3] List
supported formats in libv4l2subdev":
<URL:http://www.spinics.net/lists/linux-media/msg95377.html>
utils/media-ctl/libv4l2subdev.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c
index 33c1ee6..cce527d 100644
--- a/utils/media-ctl/libv4l2subdev.c
+++ b/utils/media-ctl/libv4l2subdev.c
@@ -769,14 +769,12 @@ enum v4l2_mbus_pixelcode v4l2_subdev_string_to_pixelcode(const char *string,
unsigned int i;
for (i = 0; i < ARRAY_SIZE(mbus_formats); ++i) {
- if (strncmp(mbus_formats[i].name, string, length) == 0)
- break;
+ if (strncmp(mbus_formats[i].name, string, length) == 0
+ && strlen(mbus_formats[i].name) == length)
+ return mbus_formats[i].code;
}
- if (i == ARRAY_SIZE(mbus_formats))
- return (enum v4l2_mbus_pixelcode)-1;
-
- return mbus_formats[i].code;
+ return (enum v4l2_mbus_pixelcode)-1;
}
static struct {
--
2.1.0.231.g7484e3b
next reply other threads:[~2015-12-09 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 15:14 Sakari Ailus [this message]
2015-12-13 21:33 ` [v4l-utils PATCH 1/1] v4l: libv4l2subdev: Precisely convert media bus string to code Laurent Pinchart
2016-01-25 11:39 ` Sakari Ailus
2016-01-25 19:41 ` Laurent Pinchart
2016-01-25 20:47 ` Sakari Ailus
2016-01-25 20:53 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449674087-19122-1-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox