From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:36052 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbaILWCI (ORCPT ); Fri, 12 Sep 2014 18:02:08 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, pawel@osciak.com, m.szyprowski@samsung.com, Hans Verkuil Subject: Re: [RFCv2 PATCH 09/14] vb2: replace 'write' by 'dma_dir' Date: Sat, 13 Sep 2014 01:02:11 +0300 Message-ID: <1451773.l8tAPSQMui@avalon> In-Reply-To: <1410526803-25887-10-git-send-email-hverkuil@xs4all.nl> References: <1410526803-25887-1-git-send-email-hverkuil@xs4all.nl> <1410526803-25887-10-git-send-email-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:58 Hans Verkuil wrote: > From: Hans Verkuil > > The 'write' argument is very ambiguous. I first assumed that if it is 1, > then we're doing video output but instead it meant the reverse. > > Since it is used to setup the dma_dir value anyway it is now replaced by > the correct dma_dir value which is unambiguous. > > Signed-off-by: Hans Verkuil Given my comments to one of your earlier patches, I can only agree with you here :-) Acked-by: Laurent Pinchart However, how about moving this patch up in the series, before adding the write argument to the alloc function ? > --- > drivers/media/v4l2-core/videobuf2-core.c | 15 +++++---- > drivers/media/v4l2-core/videobuf2-dma-contig.c | 46 ++++++++++++----------- > drivers/media/v4l2-core/videobuf2-dma-sg.c | 46 +++++++++++------------ > drivers/media/v4l2-core/videobuf2-vmalloc.c | 20 ++++++----- > include/media/videobuf2-core.h | 11 +++--- > 5 files changed, 73 insertions(+), 65 deletions(-) -- Regards, Laurent Pinchart