linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alec Leamas <leamas.alec@gmail.com>
To: mchehab@osg.samsung.com
Cc: david@hardeman.nu, austin.lund@gmail.com,
	linux-media@vger.kernel.org, Alec Leamas <leamas.alec@gmail.com>
Subject: [PATCH] Revert "[media] media/rc: Send sync space information on lirc device"
Date: Tue, 26 Jan 2016 08:11:06 +0100	[thread overview]
Message-ID: <1453792266-1542-1-git-send-email-leamas.alec@gmail.com> (raw)

This reverts commit a8f29e89f2b54fbf2c52be341f149bc195b63a8b. This
commit handled drivers failing to issue a spac which causes sequences
of mark-mark-space instead of the expected space-mark-space-mark...

The fix added an extra space for each and every timeout which fixes
the problem for the failing drivers. However, for existing working
drivers it  the added space causes mark-space-space sequences in the
output which break userspace rightfully expecting
space-mark-space-mark...

Thus, the fix is broken and reverted. The fix is discussed in
https://bugzilla.redhat.com/show_bug.cgi?id=1260862. In particular,
the original committer Austin Lund agrees.

Signed-off-by: Alec Leamas <leamas.alec@gmail.com>
---
 drivers/media/rc/ir-lirc-codec.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c
index 5effc65..8984b33 100644
--- a/drivers/media/rc/ir-lirc-codec.c
+++ b/drivers/media/rc/ir-lirc-codec.c
@@ -39,17 +39,11 @@ static int ir_lirc_decode(struct rc_dev *dev, struct ir_raw_event ev)
 		return -EINVAL;
 
 	/* Packet start */
-	if (ev.reset) {
-		/* Userspace expects a long space event before the start of
-		 * the signal to use as a sync.  This may be done with repeat
-		 * packets and normal samples.  But if a reset has been sent
-		 * then we assume that a long time has passed, so we send a
-		 * space with the maximum time value. */
-		sample = LIRC_SPACE(LIRC_VALUE_MASK);
-		IR_dprintk(2, "delivering reset sync space to lirc_dev\n");
+	if (ev.reset)
+		return 0;
 
 	/* Carrier reports */
-	} else if (ev.carrier_report) {
+	if (ev.carrier_report) {
 		sample = LIRC_FREQUENCY(ev.carrier);
 		IR_dprintk(2, "carrier report (freq: %d)\n", sample);
 
-- 
2.4.3


             reply	other threads:[~2016-01-26  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  7:11 Alec Leamas [this message]
2016-02-01 15:08 ` [PATCH] Revert "[media] media/rc: Send sync space information on lirc device" Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453792266-1542-1-git-send-email-leamas.alec@gmail.com \
    --to=leamas.alec@gmail.com \
    --cc=austin.lund@gmail.com \
    --cc=david@hardeman.nu \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).