From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
To: linux-renesas-soc@vger.kernel.org, niklas.soderlund@ragnatech.se
Cc: linux-media@vger.kernel.org, magnus.damm@gmail.com,
laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com,
ian.molton@codethink.co.uk, lars@metafoo.de,
william.towle@codethink.co.uk,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Subject: [PATCH/RFC 3/9] adv7604: fix SPA register location for ADV7612
Date: Wed, 17 Feb 2016 16:48:39 +0100 [thread overview]
Message-ID: <1455724125-13004-4-git-send-email-ulrich.hecht+renesas@gmail.com> (raw)
In-Reply-To: <1455724125-13004-1-git-send-email-ulrich.hecht+renesas@gmail.com>
SPA location LSB register is at 0x70.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/media/i2c/adv7604.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 2097c48..1680c0e 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -2110,7 +2110,8 @@ static int adv76xx_set_edid(struct v4l2_subdev *sd, struct v4l2_edid *edid)
rep_write(sd, 0x76, spa_loc & 0xff);
rep_write_clr_set(sd, 0x77, 0x40, (spa_loc & 0x100) >> 2);
} else {
- /* FIXME: Where is the SPA location LSB register ? */
+ /* ADV7612 Software Manual Rev. A, p. 15 */
+ rep_write(sd, 0x70, spa_loc & 0xff);
rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
}
--
2.6.4
next prev parent reply other threads:[~2016-02-17 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 15:48 [PATCH/RFC 0/9] Lager board HDMI input support Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 1/9] v4l: subdev: Add pad config allocator and init Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 2/9] media: adv7604: automatic "default-input" selection Ulrich Hecht
2016-02-17 15:48 ` Ulrich Hecht [this message]
2016-02-17 15:48 ` [PATCH/RFC 4/9] media: rcar_vin: Use correct pad number in try_fmt Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 5/9] media: rcar-vin: pad-aware driver initialisation Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 6/9] media: rcar-vin: add DV timings support Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 7/9] media: rcar-vin: initialize EDID data Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 8/9] ARM: shmobile: lager dts: Add entries for VIN HDMI input support Ulrich Hecht
2016-02-17 15:48 ` [PATCH/RFC 9/9] ARM: shmobile: lager dts: specify default-input for ADV7612 Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455724125-13004-4-git-send-email-ulrich.hecht+renesas@gmail.com \
--to=ulrich.hecht+renesas@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=ian.molton@codethink.co.uk \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=william.towle@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).