From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, hverkuil@xs4all.nl,
shuahkh@osg.samsung.com, laurent.pinchart@ideasonboard.com,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: [RFC 4/4] media: Drop media_get_uptr() macro
Date: Sun, 21 Feb 2016 23:36:15 +0200 [thread overview]
Message-ID: <1456090575-28354-5-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1456090575-28354-1-git-send-email-sakari.ailus@linux.intel.com>
From: Sakari Ailus <sakari.ailus@iki.fi>
There's no real need for such a macro, especially not in the user space
header.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/media-device.c | 8 ++++----
include/uapi/linux/media.h | 5 -----
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index f001c27..8a20383 100644
--- a/drivers/media/media-device.c
+++ b/drivers/media/media-device.c
@@ -256,7 +256,7 @@ static long __media_device_get_topology(struct media_device *mdev,
/* Get entities and number of entities */
i = 0;
- uentity = media_get_uptr(topo->ptr_entities);
+ uentity = (void __user *)(uintptr_t)topo->ptr_entities;
media_device_for_each_entity(entity, mdev) {
i++;
if (ret || !uentity)
@@ -282,7 +282,7 @@ static long __media_device_get_topology(struct media_device *mdev,
/* Get interfaces and number of interfaces */
i = 0;
- uintf = media_get_uptr(topo->ptr_interfaces);
+ uintf = (void __user *)(uintptr_t)topo->ptr_interfaces;
media_device_for_each_intf(intf, mdev) {
i++;
if (ret || !uintf)
@@ -317,7 +317,7 @@ static long __media_device_get_topology(struct media_device *mdev,
/* Get pads and number of pads */
i = 0;
- upad = media_get_uptr(topo->ptr_pads);
+ upad = (void __user *)(uintptr_t)topo->ptr_pads;
media_device_for_each_pad(pad, mdev) {
i++;
if (ret || !upad)
@@ -343,7 +343,7 @@ static long __media_device_get_topology(struct media_device *mdev,
/* Get links and number of links */
i = 0;
- ulink = media_get_uptr(topo->ptr_links);
+ ulink = (void __user *)(uintptr_t)topo->ptr_links;
media_device_for_each_link(link, mdev) {
if (link->is_backlink)
continue;
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index 77a95db..f4f7897 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux/media.h
@@ -353,11 +353,6 @@ struct media_v2_topology {
__u32 reserved[18];
};
-static inline void __user *media_get_uptr(__u64 arg)
-{
- return (void __user *)(uintptr_t)arg;
-}
-
/* ioctls */
#define MEDIA_IOC_DEVICE_INFO _IOWR('|', 0x00, struct media_device_info)
--
2.1.4
next prev parent reply other threads:[~2016-02-21 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 21:36 [RFC 0/4] MC v2 cleanups Sakari Ailus
2016-02-21 21:36 ` [RFC 1/4] media: Sanitise the reserved fields of the G_TOPOLOGY IOCTL arguments Sakari Ailus
2016-02-22 9:58 ` Mauro Carvalho Chehab
2016-02-22 10:00 ` Mauro Carvalho Chehab
2016-02-22 10:23 ` Mauro Carvalho Chehab
2016-02-22 19:52 ` Sakari Ailus
2016-02-21 21:36 ` [RFC 2/4] media: Rearrange the fields in the G_TOPOLOGY IOCTL argument Sakari Ailus
2016-02-22 9:54 ` Mauro Carvalho Chehab
2016-02-21 21:36 ` [RFC 3/4] media: Properly handle user pointers Sakari Ailus
2016-02-22 13:28 ` Laurent Pinchart
2016-02-21 21:36 ` Sakari Ailus [this message]
2016-02-22 9:52 ` [RFC 4/4] media: Drop media_get_uptr() macro Mauro Carvalho Chehab
2016-02-22 10:06 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456090575-28354-5-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox