From: Matthieu Rogez <matthieu.rogez@gmail.com>
To: mchehab@osg.samsung.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fix Terratec Grabby AC97 codec detection
Date: Fri, 4 Mar 2016 22:33:07 +0100 [thread overview]
Message-ID: <1457127188-7574-1-git-send-email-matthieu.rogez@gmail.com> (raw)
In-Reply-To: <20160303142621.62325571@recife.lan>
Thanks Mauro for commenting on my work.
With respect to first version, I've:
* added a timeout mecanism as requested
* added an extra check to avoid cases when the same value is constantly
returned no matter which register is accessed.
---
To test this:
* modprobe em28xx-alsa
* connect Grabby
* mplayer tv:// -tv driver=v4l2:width=720:height=576:device=/dev/video1:input=0:fps=25:norm=SECAM-L:alsa:adevice=plughw.2:audiorate=48000:forceaudio:amode=1:immediatemode=0 -nocache -fps 60
NOTE: for some unknown reason, if em28xx-alsa is not loaded when Grabby is
connected, there will be no sound.
NOTE2: if Grabby is connected without loading em28xx-alsa first, just deconnect
the Grabby and reconnect it.
next prev parent reply other threads:[~2016-03-04 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 11:26 Improve Terratec Grabby (hw rev 2) support Matthieu Rogez
2016-02-28 11:26 ` [PATCH 1/3] [media] em28xx: add support for Terratec Grabby REC button Matthieu Rogez
2016-02-28 11:26 ` [PATCH 2/3] [media] em28xx: add support for Terratec Grabby Record led Matthieu Rogez
2016-02-28 11:26 ` [PATCH 3/3] [media] em28xx: fix Terratec Grabby AC97 codec detection Matthieu Rogez
2016-03-03 17:26 ` Mauro Carvalho Chehab
2016-03-04 21:33 ` Matthieu Rogez [this message]
2016-03-04 21:33 ` [PATCH] " Matthieu Rogez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457127188-7574-1-git-send-email-matthieu.rogez@gmail.com \
--to=matthieu.rogez@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).