From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum
Date: Wed, 9 Mar 2016 16:09:24 -0300 [thread overview]
Message-ID: <1457550566-5465-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1457550566-5465-1-git-send-email-javier@osg.samsung.com>
The enum demod_pad_index list the PADs that an analog TV demod has but
in some decoders the S-Video Y (luminance) and C (chrominance) signals
are carried by different connectors. So a single DEMOD_PAD_IF_INPUT is
not enough and an additional PAD is needed in the case of S-Video for
the additional C signal.
Add a DEMOD_PAD_C_INPUT that can be used for this case and the existing
DEMOD_PAD_IF_INPUT can be used for either Composite or the Y signal.
Suggested-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Hello,
This change was suggested by Mauro in [0] although is still not clear
if this is the way forward since changing PAD indexes can break the
uAPI depending on how the PADs are looked up. Another alternative is
to have a PAD type as Mauro mentioned on the same email but since the
series are RFC, I'm making this change as an example and hopping that
the patches can help with the discussion.
[0]: http://www.spinics.net/lists/linux-media/msg98042.html
Best regards,
Javier
include/media/v4l2-mc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/media/v4l2-mc.h b/include/media/v4l2-mc.h
index 98a938aabdfb..47c00c288a06 100644
--- a/include/media/v4l2-mc.h
+++ b/include/media/v4l2-mc.h
@@ -94,7 +94,8 @@ enum if_aud_dec_pad_index {
* @DEMOD_NUM_PADS: Maximum number of output pads.
*/
enum demod_pad_index {
- DEMOD_PAD_IF_INPUT,
+ DEMOD_PAD_IF_INPUT, /* S-Video Y input or Composite */
+ DEMOD_PAD_C_INPUT, /* S-Video C input or Composite */
DEMOD_PAD_VID_OUT,
DEMOD_PAD_VBI_OUT,
DEMOD_PAD_AUDIO_OUT,
--
2.5.0
next prev parent reply other threads:[~2016-03-09 19:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:09 [RFC PATCH 0/3] [media] tvp515p: Proposal for MC input connector support Javier Martinez Canillas
2016-03-09 19:09 ` Javier Martinez Canillas [this message]
2016-03-18 15:45 ` [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum Hans Verkuil
2016-03-18 17:33 ` Hans Verkuil
2016-03-21 14:40 ` Mauro Carvalho Chehab
2016-03-21 15:05 ` Hans Verkuil
2016-03-21 16:01 ` Hans Verkuil
2016-03-21 17:50 ` Mauro Carvalho Chehab
2016-03-21 18:08 ` Hans Verkuil
2016-03-21 18:23 ` Mauro Carvalho Chehab
2016-03-21 18:48 ` Hans Verkuil
2016-03-21 18:24 ` Javier Martinez Canillas
2016-03-21 18:34 ` Mauro Carvalho Chehab
2016-03-21 18:38 ` Javier Martinez Canillas
2016-03-21 18:51 ` Hans Verkuil
2016-03-21 19:06 ` Hans Verkuil
2016-03-21 19:20 ` Javier Martinez Canillas
2016-03-21 19:30 ` Hans Verkuil
2016-03-21 19:48 ` Javier Martinez Canillas
2016-03-21 21:15 ` Mauro Carvalho Chehab
2016-03-22 0:22 ` Javier Martinez Canillas
2016-03-21 21:20 ` Mauro Carvalho Chehab
2016-03-22 0:16 ` Javier Martinez Canillas
2016-03-09 19:09 ` [RFC PATCH 2/3] [media] tvp5150: Add input connectors DT bindings Javier Martinez Canillas
2016-03-09 19:09 ` [RFC PATCH 3/3] [media] tvp5150: Replace connector support according to DT binding Javier Martinez Canillas
2016-03-18 15:01 ` [RFC PATCH 0/3] [media] tvp515p: Proposal for MC input connector support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457550566-5465-2-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).