From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from mailgw01.mediatek.com ([210.61.82.183]:35259 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754584AbcDYMm4 (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Mon, 25 Apr 2016 08:42:56 -0400
Message-ID: <1461588171.15167.10.camel@mtksdaap41>
Subject: Re: [PATCH] VPU: mediatek: fix simple_open.cocci warnings
From: andrew-ct chen <andrew-ct.chen@mediatek.com>
To: Julia Lawall <julia.lawall@lip6.fr>
CC: Tiffany Lin <tiffany.lin@mediatek.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	<daniel.thompson@linaro.org>, Rob Herring <robh+dt@kernel.org>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Pawel Osciak <posciak@chromium.org>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <PoChun.Lin@mediatek.com>,
	<kbuild-all@01.org>
Date: Mon, 25 Apr 2016 20:42:51 +0800
In-Reply-To: <alpine.DEB.2.10.1604221509350.2872@hadrien>
References: <alpine.DEB.2.10.1604221509350.2872@hadrien>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Fri, 2016-04-22 at 15:12 +0200, Julia Lawall wrote:
> Remove an open coded simple_open() function
> and replace file operations references to the function
> with simple_open() instead.
> 
> Generated by: scripts/coccinelle/api/simple_open.cocci
> 
> CC: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---

Acked-by: Andrew-CT Chen <andrew-ct.chen@mediatek.com>

> 
> I'm just passing this along.  Simple_open additionally has a check that
> inode->i_private is not NULL, before doing the assignment.  I don't know
> if that difference is important in this case.
> 
> base:   git://linuxtv.org/media_tree.git master
> 
>  mtk_vpu.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
> +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
> @@ -599,11 +599,6 @@ static void vpu_init_ipi_handler(void *d
>  }
> 
>  #ifdef CONFIG_DEBUG_FS
> -static int vpu_debug_open(struct inode *inode, struct file *file)
> -{
> -	file->private_data = inode->i_private;
> -	return 0;
> -}
> 
>  static ssize_t vpu_debug_read(struct file *file, char __user *user_buf,
>  			      size_t count, loff_t *ppos)
> @@ -646,7 +641,7 @@ static ssize_t vpu_debug_read(struct fil
>  }
> 
>  static const struct file_operations vpu_debug_fops = {
> -	.open = vpu_debug_open,
> +	.open = simple_open,
>  	.read = vpu_debug_read,
>  };
>  #endif /* CONFIG_DEBUG_FS */