Re: [RFC 08/22] videodev2.h: Add request field to v4l2_pix_format_mplane

Nicolas Dufresne
2016-05-06T16:33:14Z

Le vendredi 06 mai 2016 à 13:53 +0300, Sakari Ailus a écrit :
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Let userspace specify a request ID when getting or setting formats.
> The
> support is limited to the multi-planar API at the moment, extending
> it
> to the single-planar API is possible if needed.
>
> From a userspace point of view the API change is also minimized and
> doesn't require any new ioctl.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboar
> d.com>
> ---
>  include/uapi/linux/videodev2.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/videodev2.h
> b/include/uapi/linux/videodev2.h
> index ac28299..6260d0e 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1972,6 +1972,7 @@ struct v4l2_plane_pix_format {
>   * @ycbcr_enc: enum v4l2_ycbcr_encoding, Y'CbCr
> encoding
>   * @quantization: enum v4l2_quantization, colorspace
> quantization
>   * @xfer_func: enum v4l2_xfer_func, colorspace
> transfer function
> + * @request: request ID
>   */
>  struct v4l2_pix_format_mplane {
>   __u32 width;
> @@ -1986,7 +1987,8 @@ struct v4l2_pix_format_mplane {
>   __u8 ycbcr_enc;
>   __u8 quantization;
>   __u8 xfer_func;
> - __u8 reserved[7];
> + __u8 reserved[3];
> + __u32 request;

Shouldn't the request member be added before the padding ?

>  } __attribute__ ((packed));
>
>  /**