From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Florian Neuhaus <florian.neuhaus@reberinformatik.ch>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"sakari.ailus@iki.fi" <sakari.ailus@iki.fi>
Subject: Re: omap3isp: cropping bug in previewer?
Date: Fri, 06 Jul 2012 13:21:54 +0200 [thread overview]
Message-ID: <1464064.pfLLVkyzGQ@avalon> (raw)
In-Reply-To: <B21EB8416BB7744FAB36AEE2627158CD0119103FEC72@REBITSERVER.rebit.local>
Hi Florian,
On Friday 06 July 2012 11:55:40 Florian Neuhaus wrote:
> Hi Laurent,
>
> Laurent Pinchart wrote on 2012-07-05:
> > There's really an issue, which was introduced in v3.5-rc1. Could you
> > please try the following patch instead of yours ?
> >
> > diff --git a/drivers/media/video/omap3isp/isppreview.c
> > b/drivers/media/video/omap3isp/isppreview.c index 9c6dd44..614752a
> > 100644 --- a/drivers/media/video/omap3isp/isppreview.c +++
> > b/drivers/media/video/omap3isp/isppreview.c @@ -1116,7 +1116,7 @@ static
> > void preview_config_input_size(struct isp_prev_device *prev, u32 active)
> >
> > unsigned int elv = prev->crop.top + prev->crop.height - 1;
> > u32 features;
> >
> > - if (format->code == V4L2_MBUS_FMT_Y10_1X10) {
> > + if (format->code != V4L2_MBUS_FMT_Y10_1X10) {
> >
> > sph -= 2;
> > eph += 2;
> > slv -= 2;
>
> This patch resolves the issue for me. I get a good picture at both the
> previewer and the resizer output. Thanks for your help!
You're welcome. Can I include your
Tested-by: Florian Neuhaus <florian.neuhaus@reberinformatik.ch>
in the patch ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-07-06 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 9:55 omap3isp: cropping bug in previewer? Florian Neuhaus
2012-07-06 11:21 ` Laurent Pinchart [this message]
2012-07-06 11:45 ` AW: " Florian Neuhaus
-- strict thread matches above, loose matches on Subject: below --
2012-07-05 14:06 Florian Neuhaus
2012-07-05 16:26 ` Laurent Pinchart
2012-07-05 10:28 Florian Neuhaus
2012-07-05 10:43 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464064.pfLLVkyzGQ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=florian.neuhaus@reberinformatik.ch \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).