From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:54512 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743Ab2GSNl0 (ORCPT ); Thu, 19 Jul 2012 09:41:26 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: "Hadli, Manjunath" , dlos , LMML , Sakari Ailus , Hans Verkuil , "g.liakhovetski@gmx.de" , "Lad, Prabhakar" Subject: Re: [PATCH v4 1/2] media: add new mediabus format enums for dm365 Date: Thu, 19 Jul 2012 15:41:31 +0200 Message-ID: <1465075.iML3FpUr3Y@avalon> In-Reply-To: <201207191458.12262.hverkuil@xs4all.nl> References: <1333102154-24657-1-git-send-email-manjunath.hadli@ti.com> <201207191458.12262.hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, On Thursday 19 July 2012 14:58:12 Hans Verkuil wrote: > On Thu 19 July 2012 13:33:56 Hadli, Manjunath wrote: > > On Wed, Jul 18, 2012 at 16:35:18, Laurent Pinchart wrote: > > > On Tuesday 17 July 2012 12:22:42 Hadli, Manjunath wrote: > > > > On Tue, Jul 17, 2012 at 17:25:42, Laurent Pinchart wrote: > > > > > On Tuesday 17 July 2012 11:41:11 Hadli, Manjunath wrote: > > > > > > On Tue, Jul 17, 2012 at 16:26:24, Laurent Pinchart wrote: > > > > > > > On Friday 30 March 2012 10:09:13 Hadli, Manjunath wrote: > > > > > > > > add new enum entries for supporting the media-bus formats on > > > > > > > > dm365. > > > > > > > > These include some bayer and some non-bayer formats. > > > > > > > > V4L2_MBUS_FMT_YDYC8_1X16 and V4L2_MBUS_FMT_UV8_1X8 are used > > > > > > > > internal to the hardware by the resizer. > > > > > > > > V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8 represents the bayer ALAW > > > > > > > > format > > > > > > > > that is supported by dm365 hardware. > > > > > > > > > > > > > > > > Signed-off-by: Manjunath Hadli > > > > > > > > Cc: Laurent Pinchart > > > > > > > > Cc: Sakari Ailus > > > > > > > > Cc: Hans Verkuil > > > > > > > > --- > > > > > > > > > > > > > > > > Documentation/DocBook/media/v4l/subdev-formats.xml | 171 > > > > > > > > ++++++++++++ > > > > > > > > include/linux/v4l2-mediabus.h | 10 +- > > > > > > > > 2 files changed, 179 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git > > > > > > > > a/Documentation/DocBook/media/v4l/subdev-formats.xml > > > > > > > > b/Documentation/DocBook/media/v4l/subdev-formats.xml index > > > > > > > > 49c532e..48d92bb > > > > > > > > 100644 > > > > > > > > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > > > > > > > > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > > > > > > > > > > [snip] > > > > > > > > > > > > > @@ -965,6 +1036,56 @@ > > > > > > > > > > > > > > > > y1 > > > > > > > > y0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + > > > > > > > > > > > > > > That's a weird one. Just out of curiosity, what's the point of > > > > > > > transferring chroma information without luma ? > > > > > > > > > > > > DM365 supports this format. > > > > > > > > > > Right, but what is it used for ? > > > > > > > > Sorry about that. The Resizer in Dm365 can take only chroma and resize > > > > the buffer. It can also take luma of course. In general it can take > > > > UV8, Y8 and also UYVY. > > > > > > So UV8 is used to resize an NV buffer in two passes (first Y8 then UV8) > > > ? > > > > > No. The resizer can take has a capability to resize UV8 alone. Apart from > > this I don't see any use case for UV8. > > > > (Hans, Sakari, Guennadi, any opinion on exposing UV8 to user?) > > I have no problem with that. As far as I can tell they should be useful for > conversions between 4:2:0, 4:2:2 and 4:4:4 formats where you just want to > resize the chroma plane. Good point. I'm fine with adding explicit support for UV8 then. -- Regards, Laurent Pinchart