public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl
Subject: [PATCH v3 01/11] doc-rst: Correct the ordering of LSBs of the 10-bit raw packed formats
Date: Fri,  5 Aug 2016 13:45:31 +0300	[thread overview]
Message-ID: <1470393941-26959-2-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1470393941-26959-1-git-send-email-sakari.ailus@linux.intel.com>

The 10-bit packed raw bayer format documented that the data of the first
pixel of a four-pixel group was found in the first byte and the two
highest bits of the fifth byte. This was not entirely correct. The two
bits in the fifth byte are the two lowest bits. The second pixel occupies
the second byte and third and fourth least significant bits and so on.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Aviv Greenberg <aviv.d.greenberg@intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
---
 Documentation/media/uapi/v4l/pixfmt-srggb10p.rst | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb10p.rst b/Documentation/media/uapi/v4l/pixfmt-srggb10p.rst
index d71368f..32c067c 100644
--- a/Documentation/media/uapi/v4l/pixfmt-srggb10p.rst
+++ b/Documentation/media/uapi/v4l/pixfmt-srggb10p.rst
@@ -54,8 +54,8 @@ Each cell is one byte.
 
        -  G\ :sub:`03high`
 
-       -  B\ :sub:`00low`\ (bits 7--6) G\ :sub:`01low`\ (bits 5--4)
-	  B\ :sub:`02low`\ (bits 3--2) G\ :sub:`03low`\ (bits 1--0)
+       -  G\ :sub:`03low`\ (bits 7--6) B\ :sub:`02low`\ (bits 5--4)
+	  G\ :sub:`01low`\ (bits 3--2) B\ :sub:`00low`\ (bits 1--0)
 
     -  .. row 2
 
@@ -69,8 +69,8 @@ Each cell is one byte.
 
        -  R\ :sub:`13high`
 
-       -  G\ :sub:`10low`\ (bits 7--6) R\ :sub:`11low`\ (bits 5--4)
-	  G\ :sub:`12low`\ (bits 3--2) R\ :sub:`13low`\ (bits 1--0)
+       -  R\ :sub:`13low`\ (bits 7--6) G\ :sub:`12low`\ (bits 5--4)
+	  R\ :sub:`11low`\ (bits 3--2) G\ :sub:`10low`\ (bits 1--0)
 
     -  .. row 3
 
@@ -84,8 +84,8 @@ Each cell is one byte.
 
        -  G\ :sub:`23high`
 
-       -  B\ :sub:`20low`\ (bits 7--6) G\ :sub:`21low`\ (bits 5--4)
-	  B\ :sub:`22low`\ (bits 3--2) G\ :sub:`23low`\ (bits 1--0)
+       -  G\ :sub:`23low`\ (bits 7--6) B\ :sub:`22low`\ (bits 5--4)
+	  G\ :sub:`21low`\ (bits 3--2) B\ :sub:`20low`\ (bits 1--0)
 
     -  .. row 4
 
@@ -99,5 +99,5 @@ Each cell is one byte.
 
        -  R\ :sub:`33high`
 
-       -  G\ :sub:`30low`\ (bits 7--6) R\ :sub:`31low`\ (bits 5--4)
-	  G\ :sub:`32low`\ (bits 3--2) R\ :sub:`33low`\ (bits 1--0)
+       -  R\ :sub:`33low`\ (bits 7--6) G\ :sub:`32low`\ (bits 5--4)
+	  R\ :sub:`31low`\ (bits 3--2) G\ :sub:`30low`\ (bits 1--0)
-- 
2.7.4


  reply	other threads:[~2016-08-05 10:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 10:45 [PATCH v3 00/11] New raw bayer format definitions, fixes Sakari Ailus
2016-08-05 10:45 ` Sakari Ailus [this message]
2016-08-05 10:45 ` [PATCH v3 02/11] doc-rst: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 03/11] doc-rst: Clean up raw bayer pixel format definitions Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 04/11] doc-rst: Unify documentation of the 8-bit bayer formats Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 05/11] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-08-05 11:28   ` [PATCH v3.1 " Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 06/11] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 07/11] doc-rst: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 08/11] doc-rst: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 09/11] media: Add 1X16 16-bit raw bayer media bus code definitions Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 10/11] doc-rst: 16-bit BGGR is always 16 bits Sakari Ailus
2016-08-05 10:45 ` [PATCH v3 11/11] doc-rst: Add 16-bit raw bayer pixel format definitions Sakari Ailus
2016-08-05 11:26 ` [PATCH v3 00/11] New raw bayer format definitions, fixes Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470393941-26959-2-git-send-email-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox