Re: [PATCH v1 02/19] uvcvideo: Return 0 when setting probe control succeeds.

Laurent Pinchart
2013-09-03T20:21:37Z

Hi Pawel,

Thank you for the patch.

On Friday 30 August 2013 11:17:01 Pawel Osciak wrote:
> Return 0 instead of returning size of the probe control on successful set.

This looks good, but could you update the commit message to explain why ?

> Signed-off-by: Pawel Osciak <posciak@chromium.org>
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index 695f6d9..1198989 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -296,6 +296,8 @@ static int uvc_set_video_ctrl(struct uvc_streaming
> *stream, "%d (exp. %u).\n", probe ? "probe" : "commit",
> ret, size);
> ret = -EIO;
> + } else {
> + ret = 0;
> }
>
> kfree(data);
--
Regards,

Laurent Pinchart