Re: [PATCH v1 14/19] v4l: Add v4l2_buffer flags for VP8-specific special frames.

Hans Verkuil
2013-08-30T06:42:55Z

On 08/30/2013 04:17 AM, Pawel Osciak wrote:
> Add bits for previous, golden and altref frame types.
>
> Signed-off-by: Pawel Osciak <posciak@chromium.org>

Kamil, is this something that applies as well to your MFC driver?

> ---
> include/uapi/linux/videodev2.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 437f1b0..c011ee0 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -687,6 +687,10 @@ struct v4l2_buffer {
> #define V4L2_BUF_FLAG_TIMESTAMP_UNKNOWN 0x0000
> #define V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC 0x2000
> #define V4L2_BUF_FLAG_TIMESTAMP_COPY 0x4000
> +/* VP8 special frames */
> +#define V4L2_BUF_FLAG_PREV_FRAME 0x10000 /* VP8 prev frame */
> +#define V4L2_BUF_FLAG_GOLDEN_FRAME 0x20000 /* VP8 golden frame */
> +#define V4L2_BUF_FLAG_ALTREF_FRAME 0x40000 /* VP8 altref frame */

Would it be an idea to use the same bit values as for KEYFRAME/PFRAME/BFRAME?
After all, these can never be used at the same time. I'm a bit worried that the
bits in this field are eventually all used up by different encoder flags.

Regards,

Hans

>
> /**
> * struct v4l2_exportbuffer - export of video buffer as DMABUF file descriptor
>