From: Tiffany Lin <tiffany.lin@mediatek.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCHv2] v4l2-common: add s_selection helper function
Date: Tue, 9 Aug 2016 18:38:01 +0800 [thread overview]
Message-ID: <1470739081.10352.100.camel@mtksdaap41> (raw)
In-Reply-To: <e5ed0f02-4305-c47c-b20c-c0022e162b05@xs4all.nl>
Hi Hans,
On Fri, 2016-08-05 at 15:57 +0200, Hans Verkuil wrote:
> Hi Tiffany,
>
> We just had a long discussion about whether or not -ERANGE should be returned
> if the constraint flags could not be satisfied, and the end result was that
> the driver should not return an error in that case, but just select a rectangle
> that works with the hardware and is closest to the requested rectangle.
>
> See the irc log for the discussion:
>
> https://linuxtv.org/irc/irclogger_log/v4l?date=2016-08-05,Fri
>
> This will simplify your code, and I'll drop this patch for a v4l2-common helper
> function, since that is no longer relevant.
>
> I will try to find time to fix the documentation (since that's wrong) and any
> drivers that do return ERANGE.
Got it. I will refine and send a new patch.
best regards,
Tiffany
> Regards,
>
> Hans
prev parent reply other threads:[~2016-08-09 10:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 10:33 [PATCHv2] v4l2-common: add s_selection helper function Hans Verkuil
2016-08-04 14:03 ` Sakari Ailus
2016-08-04 14:11 ` Hans Verkuil
2016-08-04 14:17 ` Sakari Ailus
2016-08-04 14:27 ` Hans Verkuil
2016-08-04 14:38 ` Sakari Ailus
2016-08-04 14:47 ` Hans Verkuil
2016-08-04 14:59 ` Sakari Ailus
2016-08-05 13:57 ` Hans Verkuil
2016-08-09 10:38 ` Tiffany Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470739081.10352.100.camel@mtksdaap41 \
--to=tiffany.lin@mediatek.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox