From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: pavel@ucw.cz, mchehab@s-opensource.com,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [PATCH 1/1] ad5820: Use bool for boolean values
Date: Tue, 6 Sep 2016 12:35:41 +0300 [thread overview]
Message-ID: <1473154541-3983-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
The driver used integers for what boolean would have been a better fit.
Use boolean instead.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/ad5820.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index d7ad5c1..fd4c5f6 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -58,7 +58,7 @@ struct ad5820_device {
struct mutex power_lock;
int power_count;
- unsigned int standby : 1;
+ bool standby;
};
static int ad5820_write(struct ad5820_device *coil, u16 data)
@@ -108,7 +108,7 @@ static int ad5820_update_hw(struct ad5820_device *coil)
/*
* Power handling
*/
-static int ad5820_power_off(struct ad5820_device *coil, int standby)
+static int ad5820_power_off(struct ad5820_device *coil, bool standby)
{
int ret = 0, ret2;
@@ -117,7 +117,7 @@ static int ad5820_power_off(struct ad5820_device *coil, int standby)
* (single power line control for both coil and sensor).
*/
if (standby) {
- coil->standby = 1;
+ coil->standby = true;
ret = ad5820_update_hw(coil);
}
@@ -127,7 +127,7 @@ static int ad5820_power_off(struct ad5820_device *coil, int standby)
return ret2;
}
-static int ad5820_power_on(struct ad5820_device *coil, int restore)
+static int ad5820_power_on(struct ad5820_device *coil, bool restore)
{
int ret;
@@ -137,7 +137,7 @@ static int ad5820_power_on(struct ad5820_device *coil, int restore)
if (restore) {
/* Restore the hardware settings. */
- coil->standby = 0;
+ coil->standby = false;
ret = ad5820_update_hw(coil);
if (ret)
goto fail;
@@ -145,7 +145,7 @@ static int ad5820_power_on(struct ad5820_device *coil, int restore)
return 0;
fail:
- coil->standby = 1;
+ coil->standby = true;
regulator_disable(coil->vana);
return ret;
@@ -227,7 +227,8 @@ ad5820_set_power(struct v4l2_subdev *subdev, int on)
* update the power state.
*/
if (coil->power_count == !on) {
- ret = on ? ad5820_power_on(coil, 1) : ad5820_power_off(coil, 1);
+ ret = on ? ad5820_power_on(coil, true) :
+ ad5820_power_off(coil, true);
if (ret < 0)
goto done;
}
@@ -279,7 +280,7 @@ static int ad5820_suspend(struct device *dev)
if (!coil->power_count)
return 0;
- return ad5820_power_off(coil, 0);
+ return ad5820_power_off(coil, false);
}
static int ad5820_resume(struct device *dev)
@@ -291,7 +292,7 @@ static int ad5820_resume(struct device *dev)
if (!coil->power_count)
return 0;
- return ad5820_power_on(coil, 1);
+ return ad5820_power_on(coil, true);
}
#else
--
2.1.4
next reply other threads:[~2016-09-06 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 9:35 Sakari Ailus [this message]
2016-09-07 19:00 ` [PATCH 1/1] ad5820: Use bool for boolean values Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2016-09-05 7:47 Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473154541-3983-1-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).