From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com
Subject: [v4l-utils PATCH 2/2] media-ctl: Print information related to a single entity
Date: Tue, 13 Sep 2016 11:28:16 +0300 [thread overview]
Message-ID: <1473755296-14109-3-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1473755296-14109-1-git-send-email-sakari.ailus@linux.intel.com>
Add an optional argument to the -p option that allows printing all
information related to a given entity. This may be handy sometimes if only
a single entity is of interest and there are many entities.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
utils/media-ctl/media-ctl.c | 26 +++++++++++++++-----------
utils/media-ctl/options.c | 9 ++++++---
utils/media-ctl/options.h | 1 +
3 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/utils/media-ctl/media-ctl.c b/utils/media-ctl/media-ctl.c
index 0499008..fdd2449 100644
--- a/utils/media-ctl/media-ctl.c
+++ b/utils/media-ctl/media-ctl.c
@@ -504,14 +504,6 @@ static void media_print_topology_text(struct media_device *media)
media, media_get_entity(media, i));
}
-void media_print_topology(struct media_device *media, int dot)
-{
- if (dot)
- media_print_topology_dot(media);
- else
- media_print_topology_text(media);
-}
-
int main(int argc, char **argv)
{
struct media_device *media;
@@ -611,9 +603,21 @@ int main(int argc, char **argv)
}
}
- if (media_opts.print || media_opts.print_dot) {
- media_print_topology(media, media_opts.print_dot);
- printf("\n");
+ if (media_opts.print_dot) {
+ media_print_topology_dot(media);
+ } else if (media_opts.print_entity) {
+ struct media_entity *entity = NULL;
+
+ entity = media_get_entity_by_name(media,
+ media_opts.print_entity);
+ if (entity == NULL) {
+ printf("Entity '%s' not found\n",
+ media_opts.print_entity);
+ goto out;
+ }
+ media_print_topology_text_entity(media, entity);
+ } else if (media_opts.print) {
+ media_print_topology_text(media);
}
if (media_opts.reset) {
diff --git a/utils/media-ctl/options.c b/utils/media-ctl/options.c
index a288a1b..3352626 100644
--- a/utils/media-ctl/options.c
+++ b/utils/media-ctl/options.c
@@ -51,7 +51,9 @@ static void usage(const char *argv0)
printf("-i, --interactive Modify links interactively\n");
printf("-l, --links links Comma-separated list of link descriptors to setup\n");
printf(" --known-mbus-fmts List known media bus formats and their numeric values\n");
- printf("-p, --print-topology Print the device topology\n");
+ printf("-p, --print-topology [name] Print the device topology\n");
+ printf(" If entity name is specified, information to that entity\n");
+ printf(" only is printed.\n");
printf(" --print-dot Print the device topology as a dot graph\n");
printf("-r, --reset Reset all links to inactive\n");
printf("-v, --verbose Be verbose\n");
@@ -109,7 +111,7 @@ static struct option opts[] = {
{"links", 1, 0, 'l'},
{"known-mbus-fmts", 0, 0, OPT_LIST_KNOWN_MBUS_FMTS},
{"print-dot", 0, 0, OPT_PRINT_DOT},
- {"print-topology", 0, 0, 'p'},
+ {"print-topology", 2, 0, 'p'},
{"reset", 0, 0, 'r'},
{"verbose", 0, 0, 'v'},
{ },
@@ -146,7 +148,7 @@ int parse_cmdline(int argc, char **argv)
}
/* parse options */
- while ((opt = getopt_long(argc, argv, "d:e:f:hil:prvV:",
+ while ((opt = getopt_long(argc, argv, "d:e:f:hil:p::rvV:",
opts, NULL)) != -1) {
switch (opt) {
case 'd':
@@ -182,6 +184,7 @@ int parse_cmdline(int argc, char **argv)
case 'p':
media_opts.print = 1;
+ media_opts.print_entity = optarg;
break;
case 'r':
diff --git a/utils/media-ctl/options.h b/utils/media-ctl/options.h
index 9b5f314..ff9dfdf 100644
--- a/utils/media-ctl/options.h
+++ b/utils/media-ctl/options.h
@@ -30,6 +30,7 @@ struct media_options
print_dot:1,
reset:1,
verbose:1;
+ const char *print_entity;
const char *entity;
const char *formats;
const char *links;
--
2.7.4
next prev parent reply other threads:[~2016-09-13 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:28 [v4l-utils PATCH 0/2] Print information on given entity only Sakari Ailus
2016-09-13 8:28 ` [v4l-utils PATCH 1/2] media-ctl: Split off printing information related to a single entity Sakari Ailus
2016-09-13 23:34 ` Laurent Pinchart
2016-09-13 8:28 ` Sakari Ailus [this message]
2016-09-13 23:41 ` [v4l-utils PATCH 2/2] media-ctl: Print " Laurent Pinchart
2016-09-14 14:27 ` [v4l-utils PATCH v1.1 " Sakari Ailus
2016-09-14 14:29 ` [v4l-utils PATCH v1.2 " Sakari Ailus
2016-09-14 22:05 ` Laurent Pinchart
2016-09-15 6:39 ` Sakari Ailus
2016-09-15 6:40 ` [v4l-utils PATCH v1.3 " Sakari Ailus
2016-09-15 8:10 ` Laurent Pinchart
2016-09-15 8:15 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473755296-14109-3-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).