* [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
@ 2016-09-18 12:49 Baoyou Xie
2016-09-20 11:13 ` Gustavo Padovan
0 siblings, 1 reply; 7+ messages in thread
From: Baoyou Xie @ 2016-09-18 12:49 UTC (permalink / raw)
To: sumit.semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel, arnd,
baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/dma-buf/sw_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c
index 62e8e6d..6f16c85 100644
--- a/drivers/dma-buf/sw_sync.c
+++ b/drivers/dma-buf/sw_sync.c
@@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence)
* Creates a new sync_timeline. Returns the sync_timeline object or NULL in
* case of error.
*/
-struct sync_timeline *sync_timeline_create(const char *name)
+static struct sync_timeline *sync_timeline_create(const char *name)
{
struct sync_timeline *obj;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-18 12:49 [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Baoyou Xie
@ 2016-09-20 11:13 ` Gustavo Padovan
2016-09-20 12:53 ` Sumit Semwal
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo Padovan @ 2016-09-20 11:13 UTC (permalink / raw)
To: Baoyou Xie
Cc: sumit.semwal, arnd, xie.baoyou, linux-kernel, dri-devel,
linaro-mm-sig, linux-media
2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:
> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/dma-buf/sw_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for finding this.
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-20 11:13 ` Gustavo Padovan
@ 2016-09-20 12:53 ` Sumit Semwal
2016-09-22 6:57 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Sumit Semwal @ 2016-09-20 12:53 UTC (permalink / raw)
To: Gustavo Padovan, Baoyou Xie, Sumit Semwal, Arnd Bergmann,
xie.baoyou, LKML, DRI mailing list, Linaro MM SIG Mailman List,
linux-media@vger.kernel.org, Greg Kroah-Hartman
Hi Baoyou,
On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote:
> 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:
>
>> We get 1 warning when building kernel with W=1:
>> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> ---
>> drivers/dma-buf/sw_sync.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for finding this.
Thanks for the patch; this doesn't apply to mainline yet, since the
de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree.
CC'ing him.
Greg, would it be possible to please take this via your tree?
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
> Gustavo
>
Best regards,
Sumi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-20 12:53 ` Sumit Semwal
@ 2016-09-22 6:57 ` Greg Kroah-Hartman
2016-09-25 20:33 ` Gustavo Padovan
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-22 6:57 UTC (permalink / raw)
To: Sumit Semwal
Cc: Gustavo Padovan, Baoyou Xie, Arnd Bergmann, xie.baoyou, LKML,
DRI mailing list, Linaro MM SIG Mailman List,
linux-media@vger.kernel.org
On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote:
> Hi Baoyou,
>
> On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote:
> > 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:
> >
> >> We get 1 warning when building kernel with W=1:
> >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> >>
> >> In fact, this function is only used in the file in which it is
> >> declared and don't need a declaration, but can be made static.
> >> So this patch marks it 'static'.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >> ---
> >> drivers/dma-buf/sw_sync.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Thanks for finding this.
>
> Thanks for the patch; this doesn't apply to mainline yet, since the
> de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree.
> CC'ing him.
>
> Greg, would it be possible to please take this via your tree?
If someone resends it to me with the needed acks and reviewed-by, I
will.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-22 6:57 ` Greg Kroah-Hartman
@ 2016-09-25 20:33 ` Gustavo Padovan
0 siblings, 0 replies; 7+ messages in thread
From: Gustavo Padovan @ 2016-09-25 20:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Sumit Semwal, Baoyou Xie, Arnd Bergmann, xie.baoyou, LKML,
DRI mailing list, Linaro MM SIG Mailman List,
linux-media@vger.kernel.org
Hi Baoyou,
2016-09-22 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote:
> > Hi Baoyou,
> >
> > On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote:
> > > 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:
> > >
> > >> We get 1 warning when building kernel with W=1:
> > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> > >>
> > >> In fact, this function is only used in the file in which it is
> > >> declared and don't need a declaration, but can be made static.
> > >> So this patch marks it 'static'.
> > >>
> > >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > >> ---
> > >> drivers/dma-buf/sw_sync.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Thanks for finding this.
> >
> > Thanks for the patch; this doesn't apply to mainline yet, since the
> > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree.
> > CC'ing him.
> >
> > Greg, would it be possible to please take this via your tree?
>
> If someone resends it to me with the needed acks and reviewed-by, I
> will.
Could please resend this to Greg with all the acks and reviewed-by in
the commit message? Thanks.
Gustavo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
@ 2016-09-24 4:33 Baoyou Xie
2016-09-24 9:07 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Baoyou Xie @ 2016-09-24 4:33 UTC (permalink / raw)
To: sumit.semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel, arnd,
baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/dma-buf/sw_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/sw_sync.c b/drivers/dma-buf/sw_sync.c
index 62e8e6d..6f16c85 100644
--- a/drivers/dma-buf/sw_sync.c
+++ b/drivers/dma-buf/sw_sync.c
@@ -84,7 +84,7 @@ static inline struct sync_pt *fence_to_sync_pt(struct fence *fence)
* Creates a new sync_timeline. Returns the sync_timeline object or NULL in
* case of error.
*/
-struct sync_timeline *sync_timeline_create(const char *name)
+static struct sync_timeline *sync_timeline_create(const char *name)
{
struct sync_timeline *obj;
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
2016-09-24 4:33 Baoyou Xie
@ 2016-09-24 9:07 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2016-09-24 9:07 UTC (permalink / raw)
To: Baoyou Xie
Cc: sumit.semwal, linux-media, dri-devel, linaro-mm-sig, linux-kernel,
xie.baoyou
On Saturday, September 24, 2016 12:33:46 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-25 20:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-18 12:49 [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Baoyou Xie
2016-09-20 11:13 ` Gustavo Padovan
2016-09-20 12:53 ` Sumit Semwal
2016-09-22 6:57 ` Greg Kroah-Hartman
2016-09-25 20:33 ` Gustavo Padovan
-- strict thread matches above, loose matches on Subject: below --
2016-09-24 4:33 Baoyou Xie
2016-09-24 9:07 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).