From: Sean Young <sean@mess.org>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-media@vger.kernel.org
Subject: [PATCH] v4l-utils: ir-ctl: give proper error message if transmitter does not exist
Date: Mon, 19 Sep 2016 23:21:24 +0100 [thread overview]
Message-ID: <1474323685-16439-3-git-send-email-sean@mess.org> (raw)
If a transmitter does not exist when setting using -e, you get the error:
warning: /dev/lirc0: failed to set send transmitters: Success
Signed-off-by: Sean Young <sean@mess.org>
---
utils/ir-ctl/ir-ctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c
index 05b46a3..229330e 100644
--- a/utils/ir-ctl/ir-ctl.c
+++ b/utils/ir-ctl/ir-ctl.c
@@ -516,7 +516,9 @@ static int lirc_options(struct arguments *args, int fd, unsigned features)
if (args->emitters) {
if (features & LIRC_CAN_SET_TRANSMITTER_MASK) {
rc = ioctl(fd, LIRC_SET_TRANSMITTER_MASK, &args->emitters);
- if (rc)
+ if (rc > 0)
+ fprintf(stderr, _("warning: %s: failed to set send transmitters: only %d available\n"), dev, rc);
+ else if (rc < 0)
fprintf(stderr, _("warning: %s: failed to set send transmitters: %m\n"), dev);
} else
fprintf(stderr, _("warning: %s: does not support setting send transmitters\n"), dev);
--
2.7.4
reply other threads:[~2016-09-19 22:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474323685-16439-3-git-send-email-sean@mess.org \
--to=sean@mess.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).