Re: [PATCH 02/22] [media] v4l2-async: allow subdevices to add further subdevices to the notifier waiting list

Philipp Zabel
2016-10-14T17:30:48Z

Am Freitag, den 14.10.2016, 18:06 +0100 schrieb Ian Arkver:
> On 14/10/16 16:48, Philipp Zabel wrote:
> > Am Samstag, den 08.10.2016, 01:43 +0300 schrieb Sakari Ailus:
> > [...]
> > [...]
> >>> diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
> >>> index 8e2a236..e4e4b11 100644
> >>> --- a/include/media/v4l2-async.h
> >>> +++ b/include/media/v4l2-async.h
> >>> @@ -114,6 +114,18 @@ int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
> >>> struct v4l2_async_notifier *notifier);
> >>>
> >>> /**
> >>> + * __v4l2_async_notifier_add_subdev - adds a subdevice to the notifier waitlist
> >>> + *
> >>> + * @v4l2_notifier: notifier the calling subdev is bound to
> >> s/v4l2_//
> > I'd be happy to, but why should the v4l2 prefix be removed?
> >
> > regards
> > Philipp
> I think Sakari is just pointing out that the comment doesn't match the
> function argument name.

Ouch, that's very obvious now that I understand :)
Thank you for pointing this out.

regards
Philipp