Re: [PATCH 03/22] [media] v4l: of: add v4l2_of_subdev_registered

Philipp Zabel
2016-10-14T15:49:00Z

Am Freitag, den 07.10.2016, 20:50 +0200 schrieb Marek Vasut:
> On 10/07/2016 06:00 PM, Philipp Zabel wrote:
> > Provide a default registered callback for device tree probed subdevices
> > that use OF graph bindings to add still missing source subdevices to
> > the async notifier waiting list.
> > This is only necessary for subdevices that have input ports to which
> > other subdevices are connected that are not initially known to the
> > master/bridge device when it sets up the notifier.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> [...]
>
> > +int v4l2_of_subdev_registered(struct v4l2_subdev *sd)
> > +{
> > + struct device_node *ep;
> > +
> > + for_each_endpoint_of_node(sd->of_node, ep) {
> > + struct v4l2_of_link link;
> > + struct media_entity *entity;
> > + unsigned int pad;
> > + int ret;
> > +
> > + ret = v4l2_of_parse_link(ep, &link);
> > + if (ret)
> > + continue;
> > +
> > + /*
> > + * Assume 1:1 correspondence between OF node and entity,
> > + * and between OF port numbers and pad indices.
> > + */
> > + entity = &sd->entity;
>
> This here will not compile if CONFIG_MEDIA_CONTROLLER is not set,
> because ->entity will be missing from struct v4l2_subdev {} .

Thanks, I'll fix this.

regards
Philipp