Re: [PATCH 12/22] [media] tc358743: put lanes in STOP state before starting streaming

Marek Vasut
2016-10-07T19:02:36Z

On 10/07/2016 06:00 PM, Philipp Zabel wrote:
> Without calling tc358743_set_csi from the new prepare_stream callback
> (or calling tc358743_s_dv_timings or tc358743_set_fmt from userspace
> after stopping the stream), the i.MX6 MIPI CSI2 input fails waiting
> for lanes to enter STOP state when streaming is started again.

What is the impact of that failure ? How does it manifest itself ?

> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/media/i2c/tc358743.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index 1e3a0dd2..dfa45d2 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1463,6 +1463,14 @@ static int tc358743_g_mbus_config(struct v4l2_subdev *sd,
> return 0;
> }
>
> +static int tc358743_prepare_stream(struct v4l2_subdev *sd)
> +{
> + /* Put all lanes in PL-11 state (STOPSTATE) */
> + tc358743_set_csi(sd);
> +
> + return 0;
> +}
> +
> static int tc358743_s_stream(struct v4l2_subdev *sd, int enable)
> {
> enable_stream(sd, enable);
> @@ -1637,6 +1645,7 @@ static const struct v4l2_subdev_video_ops tc358743_video_ops = {
> .g_dv_timings = tc358743_g_dv_timings,
> .query_dv_timings = tc358743_query_dv_timings,
> .g_mbus_config = tc358743_g_mbus_config,
> + .prepare_stream = tc358743_prepare_stream,
> .s_stream = tc358743_s_stream,
> };
>
>

--
Best regards,
Marek Vasut