From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailgw02.mediatek.com ([210.61.82.184]:30618 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756858AbcJXL7R (ORCPT ); Mon, 24 Oct 2016 07:59:17 -0400 Message-ID: <1477310350.12745.1.camel@mtksdaap41> Subject: Re: [PATCH 2/4] mtk_mdp_vpu: remove a double unlock at the error path From: Minghsiu Tsai To: Mauro Carvalho Chehab CC: Linux Media Mailing List , "Mauro Carvalho Chehab" , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , , Date: Mon, 24 Oct 2016 19:59:10 +0800 In-Reply-To: <768767961c64dea3fdd86132c9eba87ae652d588.1477058332.git.mchehab@s-opensource.com> References: <768767961c64dea3fdd86132c9eba87ae652d588.1477058332.git.mchehab@s-opensource.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 2016-10-21 at 11:59 -0200, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:98 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock' > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > index b38d29e99f7a..5c8caa864e32 100644 > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > @@ -91,7 +91,6 @@ static int mtk_mdp_vpu_send_msg(void *msg, int len, struct mtk_mdp_vpu *vpu, > mutex_lock(&ctx->mdp_dev->vpulock); > err = vpu_ipi_send(vpu->pdev, (enum ipi_id)id, msg, len); > if (err) { > - mutex_unlock(&ctx->mdp_dev->vpulock); Hi Mauro, It has been fixed by Hans in the later patch. Author: Hans Verkuil Date: Mon Sep 19 05:00:34 2016 -0300 [media] mtk-mdp: fix double mutex_unlock Fix smatch error: media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx-> Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab minghsiu > dev_err(&ctx->mdp_dev->pdev->dev, > "vpu_ipi_send fail status %d\n", err); > }