public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: kieran.bingham+renesas@ideasonboard.com,
	niklas.soderlund+renesas@ragnatech.se,
	linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 0/4] media: adv748x: Allow probe with a single output endpoint
Date: Mon, 17 Sep 2018 18:14:10 +0300	[thread overview]
Message-ID: <14784319.JEm9TEobmr@avalon> (raw)
In-Reply-To: <1537183857-29173-1-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patches.

On Monday, 17 September 2018 14:30:53 EEST Jacopo Mondi wrote:
> Hello Laurent, Kieran, Niklas,
>    to address the Ebisu board use case, this series allows the adv748x
> driver to probe with a single output connection defined.
> 
> Compared to v2, I have dropped the last patch, as without any dynamic
> routing support it is not that helpful, and I've fixed most of commit
> messages as suggested by Kieran.
> 
> I have tested in 3 conditions on Salvator-X M3-W:
> - AFE input not registered
> - TXB not registered (Ebisu use case)
> - AFE and TXB not registered
> 
> Let me know if I can help testing this on Ebisu.

For the whole series,

Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

on Ebisu with your "[PATCH/RFT v2 0/8] arm64: dts: renesas: Ebisu: Add HDMI 
and CVBS input" patches.

The driver now probes properly and I can capture frames, but they're all black 
:-S I don't think that's related to this series though.

> v2 -> v3:
> - Drop v2 patch [5/5]
> - Add Kieran's tags and modify commit messages as he suggested
> 
> Jacopo Mondi (4):
>   media: i2c: adv748x: Support probing a single output
>   media: i2c: adv748x: Handle TX[A|B] power management
>   media: i2c: adv748x: Conditionally enable only CSI-2 outputs
>   media: i2c: adv748x: Register only enabled inputs
> 
>  drivers/media/i2c/adv748x/adv748x-afe.c  |  2 +-
>  drivers/media/i2c/adv748x/adv748x-core.c | 83  +++++++++++++++-------------
>  drivers/media/i2c/adv748x/adv748x-csi2.c | 29 ++++-------
>  drivers/media/i2c/adv748x/adv748x-hdmi.c |  2 +-
>  drivers/media/i2c/adv748x/adv748x.h      | 19 ++++++--
>  5 files changed, 68 insertions(+), 67 deletions(-)

-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2018-09-17 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 11:30 [PATCH v3 0/4] media: adv748x: Allow probe with a single output endpoint Jacopo Mondi
2018-09-17 11:30 ` [PATCH v3 1/4] media: i2c: adv748x: Support probing a single output Jacopo Mondi
2018-09-17 11:30 ` [PATCH v3 2/4] media: i2c: adv748x: Handle TX[A|B] power management Jacopo Mondi
2018-09-17 11:30 ` [PATCH v3 3/4] media: i2c: adv748x: Conditionally enable only CSI-2 outputs Jacopo Mondi
2018-09-17 11:30 ` [PATCH v3 4/4] media: i2c: adv748x: Register only enabled inputs Jacopo Mondi
2018-09-17 15:14 ` Laurent Pinchart [this message]
2018-09-26 13:47 ` [PATCH v3 0/4] media: adv748x: Allow probe with a single output endpoint Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14784319.JEm9TEobmr@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox