From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: niklas.soderlund@ragnatech.se
Subject: [PATCH 1/1] media: entity: Swap pads if route is checked from source to sink
Date: Tue, 8 Nov 2016 12:11:15 +0200 [thread overview]
Message-ID: <1478599875-27700-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
This way the pads are always passed to the has_route() op sink pad first.
Makes sense.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Hi Niklas,
This should make it easier to implement the has_route() op in drivers.
Feel free to merge this to "[PATCH 02/32] media: entity: Add
media_entity_has_route() function" if you like, or add separately after
the second patch.
drivers/media/media-entity.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index 747adcb..520f3f6 100644
--- a/drivers/media/media-entity.c
+++ b/drivers/media/media-entity.c
@@ -254,6 +254,10 @@ bool media_entity_has_route(struct media_entity *entity, unsigned int pad0,
if (!entity->ops || !entity->ops->has_route)
return true;
+ if (entity->pads[pad0].flags & MEDIA_PAD_FL_SOURCE
+ && entity->pads[pad1].flags & MEDIA_PAD_FL_SINK)
+ swap(pad0, pad1);
+
return entity->ops->has_route(entity, pad0, pad1);
}
EXPORT_SYMBOL_GPL(media_entity_has_route);
--
2.7.4
next reply other threads:[~2016-11-08 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 10:11 Sakari Ailus [this message]
2017-03-07 11:15 ` [PATCH 1/1] media: entity: Swap pads if route is checked from source to sink Niklas Söderlund
2017-03-07 11:17 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478599875-27700-1-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).