From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org, hverkuil@xs4all.nl
Cc: mchehab@osg.samsung.com, shuahkh@osg.samsung.com,
laurent.pinchart@ideasonboard.com
Subject: [RFC v4 15/21] media: Provide a way to the driver to set a private pointer
Date: Tue, 8 Nov 2016 15:55:24 +0200 [thread overview]
Message-ID: <1478613330-24691-15-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1478613330-24691-1-git-send-email-sakari.ailus@linux.intel.com>
Now that the media device can be allocated dynamically, drivers have no
longer a way to conveniently obtain the driver private data structure.
Provide one again in the form of a private pointer passed to the
media_device_alloc() function.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/media/media-device.c | 3 ++-
include/media/media-device.h | 15 ++++++++++++++-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 648c64c..7d9f76d 100644
--- a/drivers/media/media-device.c
+++ b/drivers/media/media-device.c
@@ -729,7 +729,7 @@ static void media_device_release(struct media_devnode *devnode)
kfree(mdev);
}
-struct media_device *media_device_alloc(struct device *dev)
+struct media_device *media_device_alloc(struct device *dev, void *priv)
{
struct media_device *mdev;
@@ -745,6 +745,7 @@ struct media_device *media_device_alloc(struct device *dev)
mdev->dev = dev;
media_device_init(mdev);
+ mdev->priv = priv;
mdev->devnode.release = media_device_release;
diff --git a/include/media/media-device.h b/include/media/media-device.h
index ae2bc08..94e96ef 100644
--- a/include/media/media-device.h
+++ b/include/media/media-device.h
@@ -62,6 +62,7 @@ struct media_device_ops {
* struct media_device - Media device
* @dev: Parent device
* @devnode: Media device node
+ * @priv: A pointer to driver private data
* @driver_name: Optional device driver name. If not set, calls to
* %MEDIA_IOC_DEVICE_INFO will return ``dev->driver->name``.
* This is needed for USB drivers for example, as otherwise
@@ -128,6 +129,7 @@ struct media_device {
/* dev->driver_data points to this struct. */
struct device *dev;
struct media_devnode devnode;
+ void *priv;
char model[32];
char driver_name[32];
@@ -214,6 +216,7 @@ void media_device_init(struct media_device *mdev);
* media_device_alloc() - Allocate and initialise a media device
*
* @dev: The associated struct device pointer
+ * @priv: pointer to a driver private data structure
*
* Allocate and initialise a media device. Returns a media device.
* The media device is refcounted, and this function returns a media
@@ -222,7 +225,7 @@ void media_device_init(struct media_device *mdev);
* References are taken and given using media_device_get() and
* media_device_put().
*/
-struct media_device *media_device_alloc(struct device *dev);
+struct media_device *media_device_alloc(struct device *dev, void *priv);
/**
* media_device_get() - Get a reference to a media device
@@ -249,6 +252,16 @@ struct media_device *media_device_alloc(struct device *dev);
} while (0)
/**
+ * media_device_priv() - Obtain the driver private pointer
+ *
+ * Returns a pointer passed to the media_device_alloc() function.
+ */
+static inline void *media_device_priv(struct media_device *mdev)
+{
+ return mdev->priv;
+}
+
+/**
* media_device_cleanup() - Cleanups a media device element
*
* @mdev: pointer to struct &media_device
--
2.1.4
next prev parent reply other threads:[~2016-11-08 13:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:54 [RFC v4 00/21] Make use of kref in media device, grab references as needed Sakari Ailus
2016-11-08 13:55 ` [RFC v4 01/21] Revert "[media] media: fix media devnode ioctl/syscall and unregister race" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 02/21] Revert "[media] media: fix use-after-free in cdev_put() when app exits after driver unbind" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 03/21] Revert "[media] media-device: dynamically allocate struct media_devnode" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 04/21] media: Remove useless curly braces and parentheses Sakari Ailus
2016-11-22 9:59 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 05/21] media: devnode: Rename mdev argument as devnode Sakari Ailus
2016-11-22 10:00 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 06/21] media device: Drop nop release callback Sakari Ailus
2016-11-22 10:01 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 07/21] media-device: Make devnode.dev->kobj parent of devnode.cdev Sakari Ailus
2016-11-08 13:55 ` [RFC v4 08/21] media: Enable allocating the media device dynamically Sakari Ailus
2016-11-08 19:20 ` Shuah Khan
2016-11-10 23:53 ` Laurent Pinchart
2016-11-11 0:00 ` Shuah Khan
2016-11-11 0:11 ` Laurent Pinchart
2016-11-11 0:16 ` Shuah Khan
2016-11-11 0:19 ` Laurent Pinchart
2016-11-11 0:35 ` Shuah Khan
2016-11-14 13:40 ` Sakari Ailus
2016-11-15 0:13 ` Shuah Khan
2016-11-08 13:55 ` [RFC v4 09/21] media: Split initialising and adding media devnode Sakari Ailus
2016-11-08 13:55 ` [RFC v4 10/21] media: Shuffle functions around Sakari Ailus
2016-11-08 13:55 ` [RFC v4 11/21] media device: Refcount the media device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 12/21] media device: Initialise media devnode in media_device_init() Sakari Ailus
2016-11-08 13:55 ` [RFC v4 13/21] media device: Deprecate media_device_{init,cleanup}() for drivers Sakari Ailus
2016-11-08 13:55 ` [RFC v4 14/21] media device: Get the media device driver's device Sakari Ailus
2016-11-22 9:46 ` Hans Verkuil
2016-11-22 9:58 ` Laurent Pinchart
2016-11-22 10:58 ` Hans Verkuil
2016-11-22 22:16 ` Laurent Pinchart
2016-11-08 13:55 ` Sakari Ailus [this message]
2016-11-08 13:55 ` [RFC v4 16/21] media: Add release callback for media device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 17/21] v4l: Acquire a reference to the media device for every video device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 18/21] media-device: Postpone graph object removal until free Sakari Ailus
2016-11-08 13:55 ` [RFC v4 19/21] omap3isp: Allocate the media device dynamically Sakari Ailus
2016-11-22 10:05 ` Hans Verkuil
2016-12-02 14:52 ` Sakari Ailus
2016-11-08 13:55 ` [RFC v4 20/21] omap3isp: Release the isp device struct by media device callback Sakari Ailus
2016-11-08 13:55 ` [RFC v4 21/21] omap3isp: Don't rely on devm for memory resource management Sakari Ailus
2016-11-08 17:00 ` [RFC v4 01/21] Revert "[media] media: fix media devnode ioctl/syscall and unregister race" Mauro Carvalho Chehab
2016-11-10 23:49 ` Laurent Pinchart
2016-11-22 10:01 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478613330-24691-15-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).