From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org, hverkuil@xs4all.nl
Cc: mchehab@osg.samsung.com, shuahkh@osg.samsung.com,
laurent.pinchart@ideasonboard.com,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: [RFC v4 08/21] media: Enable allocating the media device dynamically
Date: Tue, 8 Nov 2016 15:55:17 +0200 [thread overview]
Message-ID: <1478613330-24691-8-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1478613330-24691-1-git-send-email-sakari.ailus@linux.intel.com>
From: Sakari Ailus <sakari.ailus@iki.fi>
Allow allocating the media device dynamically. As the struct media_device
embeds struct media_devnode, the lifetime of that object is that same than
that of the media_device.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/media-device.c | 15 +++++++++++++++
include/media/media-device.h | 13 +++++++++++++
2 files changed, 28 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index a31329d..496195e 100644
--- a/drivers/media/media-device.c
+++ b/drivers/media/media-device.c
@@ -684,6 +684,21 @@ void media_device_init(struct media_device *mdev)
}
EXPORT_SYMBOL_GPL(media_device_init);
+struct media_device *media_device_alloc(struct device *dev)
+{
+ struct media_device *mdev;
+
+ mdev = kzalloc(sizeof(*mdev), GFP_KERNEL);
+ if (!mdev)
+ return NULL;
+
+ mdev->dev = dev;
+ media_device_init(mdev);
+
+ return mdev;
+}
+EXPORT_SYMBOL_GPL(media_device_alloc);
+
void media_device_cleanup(struct media_device *mdev)
{
ida_destroy(&mdev->entity_internal_idx);
diff --git a/include/media/media-device.h b/include/media/media-device.h
index 96de915..c9b5798 100644
--- a/include/media/media-device.h
+++ b/include/media/media-device.h
@@ -207,6 +207,15 @@ static inline __must_check int media_entity_enum_init(
void media_device_init(struct media_device *mdev);
/**
+ * media_device_alloc() - Allocate and initialise a media device
+ *
+ * @dev: The associated struct device pointer
+ *
+ * Allocate and initialise a media device. Returns a media device.
+ */
+struct media_device *media_device_alloc(struct device *dev);
+
+/**
* media_device_cleanup() - Cleanups a media device element
*
* @mdev: pointer to struct &media_device
@@ -451,6 +460,10 @@ void __media_device_usb_init(struct media_device *mdev,
const char *driver_name);
#else
+static inline struct media_device *media_device_alloc(struct device *dev)
+{
+ return NULL;
+}
static inline int media_device_register(struct media_device *mdev)
{
return 0;
--
2.1.4
next prev parent reply other threads:[~2016-11-08 13:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:54 [RFC v4 00/21] Make use of kref in media device, grab references as needed Sakari Ailus
2016-11-08 13:55 ` [RFC v4 01/21] Revert "[media] media: fix media devnode ioctl/syscall and unregister race" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 02/21] Revert "[media] media: fix use-after-free in cdev_put() when app exits after driver unbind" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 03/21] Revert "[media] media-device: dynamically allocate struct media_devnode" Sakari Ailus
2016-11-08 13:55 ` [RFC v4 04/21] media: Remove useless curly braces and parentheses Sakari Ailus
2016-11-22 9:59 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 05/21] media: devnode: Rename mdev argument as devnode Sakari Ailus
2016-11-22 10:00 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 06/21] media device: Drop nop release callback Sakari Ailus
2016-11-22 10:01 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 07/21] media-device: Make devnode.dev->kobj parent of devnode.cdev Sakari Ailus
2016-11-08 13:55 ` Sakari Ailus [this message]
2016-11-08 19:20 ` [RFC v4 08/21] media: Enable allocating the media device dynamically Shuah Khan
2016-11-10 23:53 ` Laurent Pinchart
2016-11-11 0:00 ` Shuah Khan
2016-11-11 0:11 ` Laurent Pinchart
2016-11-11 0:16 ` Shuah Khan
2016-11-11 0:19 ` Laurent Pinchart
2016-11-11 0:35 ` Shuah Khan
2016-11-14 13:40 ` Sakari Ailus
2016-11-15 0:13 ` Shuah Khan
2016-11-08 13:55 ` [RFC v4 09/21] media: Split initialising and adding media devnode Sakari Ailus
2016-11-08 13:55 ` [RFC v4 10/21] media: Shuffle functions around Sakari Ailus
2016-11-08 13:55 ` [RFC v4 11/21] media device: Refcount the media device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 12/21] media device: Initialise media devnode in media_device_init() Sakari Ailus
2016-11-08 13:55 ` [RFC v4 13/21] media device: Deprecate media_device_{init,cleanup}() for drivers Sakari Ailus
2016-11-08 13:55 ` [RFC v4 14/21] media device: Get the media device driver's device Sakari Ailus
2016-11-22 9:46 ` Hans Verkuil
2016-11-22 9:58 ` Laurent Pinchart
2016-11-22 10:58 ` Hans Verkuil
2016-11-22 22:16 ` Laurent Pinchart
2016-11-08 13:55 ` [RFC v4 15/21] media: Provide a way to the driver to set a private pointer Sakari Ailus
2016-11-08 13:55 ` [RFC v4 16/21] media: Add release callback for media device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 17/21] v4l: Acquire a reference to the media device for every video device Sakari Ailus
2016-11-08 13:55 ` [RFC v4 18/21] media-device: Postpone graph object removal until free Sakari Ailus
2016-11-08 13:55 ` [RFC v4 19/21] omap3isp: Allocate the media device dynamically Sakari Ailus
2016-11-22 10:05 ` Hans Verkuil
2016-12-02 14:52 ` Sakari Ailus
2016-11-08 13:55 ` [RFC v4 20/21] omap3isp: Release the isp device struct by media device callback Sakari Ailus
2016-11-08 13:55 ` [RFC v4 21/21] omap3isp: Don't rely on devm for memory resource management Sakari Ailus
2016-11-08 17:00 ` [RFC v4 01/21] Revert "[media] media: fix media devnode ioctl/syscall and unregister race" Mauro Carvalho Chehab
2016-11-10 23:49 ` Laurent Pinchart
2016-11-22 10:01 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478613330-24691-8-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).