From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:38603 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964929AbcKKIyT (ORCPT ); Fri, 11 Nov 2016 03:54:19 -0500 From: Shailendra Verma To: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Staging: media: davinci_vpfe: - Fix for memory leak if Date: Fri, 11 Nov 2016 14:21:41 +0530 Message-id: <1478854301-25466-1-git-send-email-shailendra.v@samsung.com> Sender: linux-media-owner@vger.kernel.org List-ID: From: "Shailendra Verma" Fix to avoid possible memory leak if the decoder initialization got failed.Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c index 8be9f85..80c2e25 100644 --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c @@ -423,6 +423,7 @@ static int vpfe_open(struct file *file) /* If decoder is not initialized. initialize it */ if (!video->initialized && vpfe_update_pipe_state(video)) { mutex_unlock(&video->lock); + kfree(handle); return -ENODEV; } /* Increment device users counter */ -- 1.7.9.5