From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
To: linux-renesas-soc@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
magnus.damm@gmail.com,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH v1.5 1/6] v4l: rcar-fcp: Don't get/put module reference
Date: Fri, 9 Dec 2016 13:35:07 +0100 [thread overview]
Message-ID: <1481286912-16555-2-git-send-email-ulrich.hecht+renesas@gmail.com> (raw)
In-Reply-To: <1481286912-16555-1-git-send-email-ulrich.hecht+renesas@gmail.com>
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Direct callers of the FCP API hold a reference to the FCP module due to
module linkage, there's no need to take another one manually. Take a
reference to the device instead to ensure that it won't disappear behind
the caller's back.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/media/platform/rcar-fcp.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
index 7146fc5..e9f609e 100644
--- a/drivers/media/platform/rcar-fcp.c
+++ b/drivers/media/platform/rcar-fcp.c
@@ -53,14 +53,7 @@ struct rcar_fcp_device *rcar_fcp_get(const struct device_node *np)
if (fcp->dev->of_node != np)
continue;
- /*
- * Make sure the module won't be unloaded behind our back. This
- * is a poor man's safety net, the module should really not be
- * unloaded while FCP users can be active.
- */
- if (!try_module_get(fcp->dev->driver->owner))
- fcp = NULL;
-
+ get_device(fcp->dev);
goto done;
}
@@ -81,7 +74,7 @@ EXPORT_SYMBOL_GPL(rcar_fcp_get);
void rcar_fcp_put(struct rcar_fcp_device *fcp)
{
if (fcp)
- module_put(fcp->dev->driver->owner);
+ put_device(fcp->dev);
}
EXPORT_SYMBOL_GPL(rcar_fcp_put);
--
2.7.4
next prev parent reply other threads:[~2016-12-09 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 12:35 [PATCH v1.5 0/6] R-Car DU: Fix IOMMU operation when connected to VSP Ulrich Hecht
2016-12-09 12:35 ` Ulrich Hecht [this message]
2016-12-09 12:35 ` [PATCH v1.5 2/6] v4l: rcar-fcp: Add an API to retrieve the FCP device Ulrich Hecht
2016-12-09 12:35 ` [PATCH v1.5 3/6] v4l: vsp1: Add API to map and unmap DRM buffers through the VSP Ulrich Hecht
2016-12-09 12:35 ` [PATCH v1.5 4/6] drm: rcar-du: Map memory through the VSP device Ulrich Hecht
2016-12-09 12:35 ` [PATCH v1.5 5/6] v4l: vsp1: Provide display list and VB2 queue with FCP device Ulrich Hecht
2016-12-09 12:35 ` [PATCH v1.5 6/6] arm64: dts: r8a7796: Connect FCP devices to IPMMU Ulrich Hecht
2017-08-30 8:46 ` [PATCH v1.5 0/6] R-Car DU: Fix IOMMU operation when connected to VSP Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481286912-16555-2-git-send-email-ulrich.hecht+renesas@gmail.com \
--to=ulrich.hecht+renesas@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).