From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:53646 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdBFI5Q (ORCPT ); Mon, 6 Feb 2017 03:57:16 -0500 Subject: Re: [PATCH 06/11] [media] videodev2.h: Add v4l2 definition for HEVC From: Smitha T Murthy To: Andrzej Hajda Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com In-reply-to: Content-type: text/plain; charset=UTF-8 Date: Mon, 06 Feb 2017 14:11:41 +0530 Message-id: <1486370501.16927.84.camel@smitha-fedora> MIME-version: 1.0 Content-transfer-encoding: 7bit References: <1484733729-25371-1-git-send-email-smitha.t@samsung.com> <1484733729-25371-7-git-send-email-smitha.t@samsung.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, 2017-02-02 at 09:34 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > Beside small nitpick. > > Reviewed-by: Andrzej Hajda > > > --- > > include/uapi/linux/videodev2.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 46e8a2e3..620e941 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -630,6 +630,7 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_VC1_ANNEX_L v4l2_fourcc('V', 'C', '1', 'L') /* SMPTE 421M Annex L compliant stream */ > > #define V4L2_PIX_FMT_VP8 v4l2_fourcc('V', 'P', '8', '0') /* VP8 */ > > #define V4L2_PIX_FMT_VP9 v4l2_fourcc('V', 'P', '9', '0') /* VP9 */ > > +#define V4L2_PIX_FMT_HEVC v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC */ > > I am not sure if it shouldn't be sorted alphabetically in compressed > formats stanza. > > -- > Regards > Andrzej Actually the formats are not arranged alphabetically. For example #define V4L2_PIX_FMT_XVID is added before the #define V4L2_PIX_FMT_VC1_ANNEX_G. Hence I added the definition at the end. If required, I will take this as a separate patch. Thank you for the review. Regards, Smitha > > > > > /* Vendor-specific formats */ > > #define V4L2_PIX_FMT_CPIA1 v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */ > > >