* Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex
2017-02-09 22:10 ` [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex Shuah Khan
@ 2017-02-10 2:01 ` Nicolas Dufresne
2017-02-10 7:18 ` Andrzej Hajda
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dufresne @ 2017-02-10 2:01 UTC (permalink / raw)
To: Shuah Khan, kyungmin.park, kamil, jtp.park, a.hajda, mchehab
Cc: linux-arm-kernel, linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
Le jeudi 09 février 2017 à 15:10 -0700, Shuah Khan a écrit :
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to
> be
> consistent with the rest of the messages in the routine.
Short and long descriptions are miss-leading. This patch will print the
buffer pointer as hex and keep the size as decimal. I think the patch
correctly improves consistency, the comment should match the code.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct
> s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been
> allocated.\n");
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex
2017-02-09 22:10 ` [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex Shuah Khan
2017-02-10 2:01 ` Nicolas Dufresne
@ 2017-02-10 7:18 ` Andrzej Hajda
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2017-02-10 7:18 UTC (permalink / raw)
To: Shuah Khan, kyungmin.park, kamil, jtp.park, mchehab
Cc: linux-arm-kernel, linux-media, linux-kernel
On 09.02.2017 23:10, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to be
> consistent with the rest of the messages in the routine.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
As Nicolas said please fix the subject.
After this you can add my:
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been allocated.\n");
^ permalink raw reply [flat|nested] 3+ messages in thread