From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37417 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbdBMKCp (ORCPT ); Mon, 13 Feb 2017 05:02:45 -0500 Message-ID: <1486980162.2873.33.camel@pengutronix.de> Subject: Re: [PATCH v2 4/4] media-ctl: add colorimetry support From: Philipp Zabel To: Sakari Ailus Cc: Hans Verkuil , linux-media@vger.kernel.org, Laurent Pinchart , Steve Longerbeam Date: Mon, 13 Feb 2017 11:02:42 +0100 In-Reply-To: <20170213094823.GG16975@valkosipuli.retiisi.org.uk> References: <1486978408-28580-1-git-send-email-p.zabel@pengutronix.de> <1486978408-28580-4-git-send-email-p.zabel@pengutronix.de> <1958d6aa-b5ba-9e8f-aa34-d08a54843c47@xs4all.nl> <20170213094823.GG16975@valkosipuli.retiisi.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 2017-02-13 at 11:48 +0200, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 13, 2017 at 10:40:41AM +0100, Hans Verkuil wrote: > ... > > > @@ -839,6 +951,157 @@ enum v4l2_field v4l2_subdev_string_to_field(const char *string) > > > return (enum v4l2_field)-1; > > > } > > > > > > +static struct { > > > + const char *name; > > > + enum v4l2_colorspace colorspace; > > > +} colorspaces[] = { > > > + { "default", V4L2_COLORSPACE_DEFAULT }, > > > + { "smpte170m", V4L2_COLORSPACE_SMPTE170M }, > > > + { "smpte240m", V4L2_COLORSPACE_SMPTE240M }, > > > + { "rec709", V4L2_COLORSPACE_REC709 }, > > > + { "bt878", V4L2_COLORSPACE_BT878 }, > > > > Drop this, it's no longer used in the kernel. > > What about older kernels? Were there drivers that reported it? Has there ever been a v4l2 subdevice that reported bt878 colorspace on a pad via VIDIOC_SUBDEV_G_FMT? regards Philipp