From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:11385 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdCAW0L (ORCPT ); Wed, 1 Mar 2017 17:26:11 -0500 Message-ID: <1488407166.12062.4.camel@linux.intel.com> Subject: Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings From: Alan Cox To: Daniel =?ISO-8859-1?Q?Gl=F6ckner?= Cc: Greg Kroah-Hartman , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 01 Mar 2017 22:26:06 +0000 In-Reply-To: <20170301215858.GA25346@minime.bse> References: <201703011837.1R4zsbQi%fengguang.wu@intel.com> <20170301103017.GA30536@lkp-wsm-ep1> <20170301215858.GA25346@minime.bse> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 2017-03-01 at 22:58 +0100, Daniel Glöckner wrote: > On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote: > > > > drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to > > set .owner here. The core will do it. > > > >  Remove .owner field if calls are used which set it automatically > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > CC: Alan Cox > > Signed-off-by: Fengguang Wu > > > May I ask which repository this patch is based on? It's a major clean up from internal code. For various reasons the previous history of the code can't be exposed (the internal repository we have contains code that can't go out of Intel for example). > Does Intel finally attempt to upstream the atomisp driver? That's the goal for the ISP 2 driver (Baytrail/T and later Cherrytrail). I can't speak for longer term plans with ISP 3 and later devices which currently don't have upstream drivers. There are some bits of support in ISP2 for some of the odder phone platforms as well but I don't have a way to test them or think anyone cares so plan to drop those. Alan