From: simran singhal <singhalsimran0@gmail.com>
To: mchehab@kernel.org
Cc: gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: [PATCH 5/7] staging: media: Remove multiple assignments
Date: Fri, 3 Mar 2017 01:22:00 +0530 [thread overview]
Message-ID: <1488484322-5928-5-git-send-email-singhalsimran0@gmail.com> (raw)
In-Reply-To: <1488484322-5928-1-git-send-email-singhalsimran0@gmail.com>
Remove multiple assignments by factorizing them. Problem found using
checkpatch.pl
CHECK: multiple assignments should be avoided
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 198df22..165dcb3 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -259,7 +259,8 @@ static int gc2235_get_intg_factor(struct i2c_client *client,
return -EINVAL;
/* pixel clock calculattion */
- buf->vt_pix_clk_freq_mhz = dev->vt_pix_clk_freq_mhz = 30000000;
+ buf->vt_pix_clk_freq_mhz = 30000000;
+ dev->vt_pix_clk_freq_mhz = 30000000;
/* get integration time */
buf->coarse_integration_time_min = GC2235_COARSE_INTG_TIME_MIN;
--
2.7.4
next prev parent reply other threads:[~2017-03-02 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 19:51 [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant simran singhal
2017-03-02 19:51 ` [PATCH 2/7] staging: media: Add blank line after a declaration simran singhal
2017-03-02 19:51 ` [PATCH 3/7] staging: media: Replace NULL with "!" simran singhal
2017-03-02 19:51 ` [PATCH 4/7] staging: media: Remove blank line before '}' and after '{' braces simran singhal
2017-03-02 19:52 ` simran singhal [this message]
2017-03-02 19:52 ` [PATCH 6/7] staging: media: Use x instead of x != NULL simran singhal
2017-03-02 19:52 ` [PATCH 7/7] staging: media: Do not use multiple blank lines simran singhal
2017-03-03 17:45 ` [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant Sakari Ailus
2017-03-03 18:23 ` SIMRAN SINGHAL
2017-03-03 18:37 ` [Outreachy kernel] " Julia Lawall
2017-03-09 16:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488484322-5928-5-git-send-email-singhalsimran0@gmail.com \
--to=singhalsimran0@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).