From: Philipp Zabel <p.zabel@pengutronix.de>
To: Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] [media] coda: implement encoder stop command
Date: Fri, 03 Mar 2017 12:50:13 +0100 [thread overview]
Message-ID: <1488541813.2196.52.camel@pengutronix.de> (raw)
In-Reply-To: <CAH-u=83Jib=vFPXQTsfojssrR3h8eXzm_1imufZ9NKJ=0DPdgw@mail.gmail.com>
On Thu, 2017-03-02 at 17:30 +0100, Jean-Michel Hautbois wrote:
> <snip>
>
> > + /* If there is no buffer in flight, wake up */
> > + if (ctx->qsequence == ctx->osequence) {
>
> Not sure about this one, I would have done something like :
> if (!(ctx->fh.m2m_ctx->job_flags)) {
This field is documented as "used internally", though.
regards
Philipp
prev parent reply other threads:[~2017-03-03 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 9:51 [PATCH] [media] coda: implement encoder stop command Philipp Zabel
2017-03-02 10:02 ` Jean-Michel Hautbois
2017-03-02 10:16 ` Philipp Zabel
2017-03-02 16:30 ` Jean-Michel Hautbois
2017-03-03 11:50 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488541813.2196.52.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=jean-michel.hautbois@veo-labs.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).