From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailgw02.mediatek.com ([210.61.82.184]:40593 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932166AbdCUBqo (ORCPT ); Mon, 20 Mar 2017 21:46:44 -0400 Message-ID: <1490060789.27725.9.camel@mtksdaap41> Subject: Re: [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as __maybe_unused From: Rick Chang To: Arnd Bergmann CC: Bin Liu , Mauro Carvalho Chehab , Matthias Brugger , "Minghsiu Tsai" , Ricky Liang , , , , , "Hans Verkuil" Date: Tue, 21 Mar 2017 09:46:29 +0800 In-Reply-To: <20170320094812.1365229-2-arnd@arndb.de> References: <20170320094812.1365229-1-arnd@arndb.de> <20170320094812.1365229-2-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 2017-03-20 at 10:47 +0100, Arnd Bergmann wrote: > When CONFIG_PM is disabled, we get a couple of unused functions: > > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:927:13: error: 'mtk_jpeg_clk_off' defined but not used [-Werror=unused-function] > static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg) > ^~~~~~~~~~~~~~~~ > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:916:13: error: 'mtk_jpeg_clk_on' defined but not used [-Werror=unused-function] > static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg) > > Rather than adding more error-prone #ifdefs around those, this patch > removes the existing #ifdef checks and marks the PM functions as __maybe_unused > to let gcc do the right thing. > > Signed-off-by: Arnd Bergmann > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) Acked-by: Rick Chang