From: Alan Cox <alan@linux.intel.com>
To: "Geliang Tang" <geliangtang@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>,
"Varsha Rao" <rvarsha016@gmail.com>
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: fix build error
Date: Thu, 23 Mar 2017 15:59:51 +0000 [thread overview]
Message-ID: <1490284791.5934.45.camel@linux.intel.com> (raw)
In-Reply-To: <328d0eb3da461aaaa6140b1409ee7550bcec87bb.1490261279.git.geliangtang@gmail.com>
On Thu, 2017-03-23 at 21:12 +0800, Geliang Tang wrote:
> Fix the following build error:
>
> CC drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2:
> error: excess elements in array initializer [-Werror]
> "i", /* ion */
> ^~~
NAK
I've sent a patch to sort this out properly we shouldn't be using
string arrays for single char values to start with...
Alan
prev parent reply other threads:[~2017-03-23 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:12 [PATCH] staging: media: atomisp: fix build error Geliang Tang
2017-03-23 13:12 ` [PATCH] staging: media: atomisp: use kvmalloc and kvfree Geliang Tang
2017-03-23 13:37 ` Greg Kroah-Hartman
2017-03-23 15:59 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490284791.5934.45.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=geliangtang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.lefaure@lse.epita.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).