From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:42643 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752391AbdFHFQc (ORCPT ); Thu, 8 Jun 2017 01:16:32 -0400 Message-ID: <1496898982.1929.7.camel@perches.com> Subject: Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs From: Joe Perches To: Tomasz Figa , Hirokazu Honda , Hans Verkuil Cc: Pawel Osciak , Kyungmin Park , Marek Szyprowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Wed, 07 Jun 2017 22:16:22 -0700 In-Reply-To: References: <20170530094901.1807-1-hiroh@chromium.org> <1496139572.2618.19.camel@perches.com> <1496196991.2618.47.camel@perches.com> <1496203602.2618.54.camel@perches.com> <0eb529d9-a710-4305-f0e2-e2fcd5d5433a@xs4all.nl> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, 2017-06-08 at 13:39 +0900, Tomasz Figa wrote: > On Thu, Jun 8, 2017 at 12:24 PM, Hirokazu Honda wrote: > > Hi, > > > > I completely understand bitmask method now. > > I agree to the idea, but it is necessary to change the specification of > > a debug parameter. > > (We probably need to change a document about that?) > > For example, there is maybe a user who set a debug parameter 3. > > The user assume that logs whose levels are less than 4 are shown. > > However, after the bitmask method is adopted, someday the logs whose > > level is 1 or 2 are only shown, not 3 level logs are not shown. > > This will be confusing to users. > > I think I have to agree with Hirokazu here. Even though it's only > about debugging, there might be some automatic testing systems that > actually rely on certain values here. I think it's a non-argument. If there automated systems that rely on specific levels, then changing the levels of individual messages could also cause those automated systems to fail.