From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Mats Randgaard <matrandg@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config
Date: Thu, 21 Sep 2017 11:21:57 +0200 [thread overview]
Message-ID: <1505985717.10081.4.camel@pengutronix.de> (raw)
In-Reply-To: <f6e576dde2640bcf6a79d157f83c96ca13c453a3.1505826082.git.dave.stevenson@raspberrypi.org>
On Tue, 2017-09-19 at 14:08 +0100, Dave Stevenson wrote:
> Support for non-continuous clock had previously been added via
> device tree, but a comment and the value reported by g_mbus_config
> still stated that it wasn't supported.
> Remove the comment, and return the correct value in g_mbus_config.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> ---
> drivers/media/i2c/tc358743.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/tc358743.c
> b/drivers/media/i2c/tc358743.c
> index e6f5c36..6b0fd07 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1461,8 +1461,9 @@ static int tc358743_g_mbus_config(struct
> v4l2_subdev *sd,
>
> cfg->type = V4L2_MBUS_CSI2;
>
> - /* Support for non-continuous CSI-2 clock is missing in the
> driver */
> - cfg->flags = V4L2_MBUS_CSI2_CONTINUOUS_CLOCK;
> + cfg->flags = state->bus.flags &
> + (V4L2_MBUS_CSI2_CONTINUOUS_CLOCK |
> + V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK);
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2017-09-21 9:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 13:08 [PATCH 0/3] [media] tc358743: Support for a wider range of inputs Dave Stevenson
2017-09-19 13:08 ` [PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config Dave Stevenson
2017-09-21 9:21 ` Philipp Zabel [this message]
2017-09-19 13:08 ` [PATCH 2/3] [media] tc358743: Increase FIFO level to 300 Dave Stevenson
2017-09-19 15:24 ` Philipp Zabel
2017-09-19 16:49 ` Mauro Carvalho Chehab
2017-09-20 9:14 ` Dave Stevenson
2017-09-20 10:23 ` Philipp Zabel
2017-09-20 11:00 ` Dave Stevenson
2017-09-20 11:24 ` Hans Verkuil
2017-09-20 12:23 ` Dave Stevenson
2017-09-20 12:37 ` Hans Verkuil
2017-09-20 12:36 ` Philipp Zabel
2017-09-20 12:50 ` Sakari Ailus
2017-09-20 13:12 ` Hans Verkuil
2017-09-21 6:35 ` Sakari Ailus
2017-09-21 9:04 ` Philipp Zabel
2017-09-19 13:08 ` [PATCH 3/3] [media] tc358743: Add support for 972Mbit/s link freq Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505985717.10081.4.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dave.stevenson@raspberrypi.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=matrandg@cisco.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).