From: Philipp Zabel <p.zabel@pengutronix.de>
To: Ian Arkver <ian.arkver.dev@gmail.com>, linux-media@vger.kernel.org
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Hans Verkuil <hansverk@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Mats Randgaard <matrandg@cisco.com>
Subject: Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting
Date: Thu, 21 Sep 2017 14:35:54 +0200 [thread overview]
Message-ID: <1505997354.10081.11.camel@pengutronix.de> (raw)
In-Reply-To: <9518ed83-48da-472f-f895-4cd4c3797373@gmail.com>
Hi Ian,
On Thu, 2017-09-21 at 12:06 +0100, Ian Arkver wrote:
[...]
> > My understanding of Hans' comment:
> > "I'd also add a comment that all other flags must be 0 if the device
> > tree is used. This to avoid mixing the two."
> >
> > is that all the above should only happen if (!!state->pdata).
>
> Except that state->pdata is a copy of the pdata, not a pointer, but you
> know what I mean. Some other check for DT needed here.
Yes, I'll change this to zero all V4L2_MBUS_CSI2_[1-4]_LANE in the DT
case. I suppose the V4L2_MBUS_CSI2_CONTINUOUS_CLOCK and
V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK bits should be zeroed as well, then?
> > I don't know if this would break any existing DT-using bridge drivers.
The only current users of g_mbus_config are the pxa_camera and
sh_mobile_ceu_camera soc_camera drivers. Neither supports MIPI CSI-2, as
far as I can tell.
regards
Philipp
next prev parent reply other threads:[~2017-09-21 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 10:24 [PATCH] tc358743: fix connected/active CSI-2 lane reporting Philipp Zabel
2017-09-21 11:04 ` Ian Arkver
2017-09-21 11:06 ` Ian Arkver
2017-09-21 12:35 ` Philipp Zabel [this message]
2017-09-21 14:01 ` Hans Verkuil
2017-09-21 11:41 ` Dave Stevenson
2017-09-21 12:31 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505997354.10081.11.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dave.stevenson@raspberrypi.org \
--cc=hansverk@cisco.com \
--cc=ian.arkver.dev@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=matrandg@cisco.com \
--cc=mchehab@s-opensource.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox